From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Eric Miao <eric.y.miao@gmail.com>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH] ALSA: ASoC: fix PXA SSP port resume
Date: Tue, 02 Feb 2010 10:51:28 +0000 [thread overview]
Message-ID: <1265107888.4194.59.camel@odin> (raw)
In-Reply-To: <1265081575-24583-1-git-send-email-daniel@caiaq.de>
Looks fine except for commit message (sorry to nitpick).
On Tue, 2010-02-02 at 11:32 +0800, Daniel Mack wrote:
> Unconditionally save the register states in resume
I assume you mean suspend here ?
> and restore them
> again at resume time. Register contents are not preserved over suspend,
were not being preserved
> and the driver takes false assumptions about them otherwise.
>
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-02-02 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 10:34 [PATCH] ALSA: ASoC: fix PXA SSP port resume Daniel Mack
2010-01-29 10:13 ` Mark Brown
2010-01-29 11:08 ` Daniel Mack
2010-01-29 14:00 ` Mark Brown
2010-02-02 3:32 ` Daniel Mack
2010-02-02 10:51 ` Liam Girdwood [this message]
2010-02-02 10:45 ` Daniel Mack
2010-02-02 11:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265107888.4194.59.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=daniel@caiaq.de \
--cc=eric.y.miao@gmail.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox