[PATCH] ASoC: pandora: Add APLL supply to fix audio output

[PATCH] ASoC: pandora: Add APLL supply to fix audio output

[Grazvydas Ignotas]

Pandora's external DAC is using 256*Fs output from the TWL4030
codec, and TWL4030 needs to have APLL enabled for it's 256*Fs
output to function.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
---
I noticed this a bit late because TWL4030 codec used to have APLL
enable hardcoded until that was clean up by not-so-old patch.
Would be nice to see this in next -rc, as without this audio
won't work completely on pandora (again)..

 sound/soc/omap/omap3pandora.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c
index 71b2c16..68980c1 100644
--- a/sound/soc/omap/omap3pandora.c
+++ b/sound/soc/omap/omap3pandora.c
@@ -145,6 +145,7 @@ static const struct snd_soc_dapm_widget omap3pandora_in_dapm_widgets[] = {
 };
 
 static const struct snd_soc_dapm_route omap3pandora_out_map[] = {
+	{"PCM DAC", NULL, "APLL Enable"},
 	{"Headphone Amplifier", NULL, "PCM DAC"},
 	{"Line Out", NULL, "PCM DAC"},
 	{"Headphone Jack", NULL, "Headphone Amplifier"},
-- 
1.6.3.3

Re: [PATCH] ASoC: pandora: Add APLL supply to fix audio output

[Peter Ujfalusi]

On Friday 05 February 2010 00:55:33 ext Grazvydas Ignotas wrote:
> Pandora's external DAC is using 256*Fs output from the TWL4030
> codec, and TWL4030 needs to have APLL enabled for it's 256*Fs
> output to function.
> 
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> I noticed this a bit late because TWL4030 codec used to have APLL
> enable hardcoded until that was clean up by not-so-old patch.
> Would be nice to see this in next -rc, as without this audio
> won't work completely on pandora (again)..

Yeah, when I made the changes to the twl4030 codec, I did missed the pandora 
setup..

Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Re: [PATCH] ASoC: pandora: Add APLL supply to fix audio output

[Liam Girdwood]

On Fri, 2010-02-05 at 08:50 +0200, Peter Ujfalusi wrote:
> On Friday 05 February 2010 00:55:33 ext Grazvydas Ignotas wrote:
> > Pandora's external DAC is using 256*Fs output from the TWL4030
> > codec, and TWL4030 needs to have APLL enabled for it's 256*Fs
> > output to function.
> > 
> > Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> > ---
> > I noticed this a bit late because TWL4030 codec used to have APLL
> > enable hardcoded until that was clean up by not-so-old patch.
> > Would be nice to see this in next -rc, as without this audio
> > won't work completely on pandora (again)..
> 
> Yeah, when I made the changes to the twl4030 codec, I did missed the pandora 
> setup..
> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

Btw, I may be getting a pandora soon so I should be able to keep on top
of any future breakages.

Liam

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: [PATCH] ASoC: pandora: Add APLL supply to fix audio output

[Mark Brown]

On Fri, Feb 05, 2010 at 10:13:21AM +0000, Liam Girdwood wrote:
> On Fri, 2010-02-05 at 08:50 +0200, Peter Ujfalusi wrote:
> > On Friday 05 February 2010 00:55:33 ext Grazvydas Ignotas wrote:
> > > Pandora's external DAC is using 256*Fs output from the TWL4030
> > > codec, and TWL4030 needs to have APLL enabled for it's 256*Fs
> > > output to function.
> > > 
> > > Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> > > ---
> > > I noticed this a bit late because TWL4030 codec used to have APLL
> > > enable hardcoded until that was clean up by not-so-old patch.
> > > Would be nice to see this in next -rc, as without this audio
> > > won't work completely on pandora (again)..
> > 
> > Yeah, when I made the changes to the twl4030 codec, I did missed the pandora 
> > setup..
> > 
> > Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> 
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

Applied, thanks.