From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH -next] ASoC: pandora: Add DAC regulator support
Date: Fri, 05 Feb 2010 15:16:50 +0000 [thread overview]
Message-ID: <1265383010.3177.13.camel@odin> (raw)
In-Reply-To: <6ed0b2681002050629p1d38c19m19d1a124ddce307a@mail.gmail.com>
On Fri, 2010-02-05 at 16:29 +0200, Grazvydas Ignotas wrote:
> On Fri, Feb 5, 2010 at 4:08 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> > On Fri, 2010-02-05 at 15:13 +0200, Grazvydas Ignotas wrote:
> >> Pandora's external DAC is connected to VSIM TWL4030 supply, so let's
> >> start switching it too to save more power.
> >>
> >> Also DAC got it's own DAPM handler and the delay was removed
> >> (it gave on audible improvement).
> >>
> >
> > That's good to hear (pun intended).
>
> Uh, I meant "no audible improvement". However I've just checked the
> DAC datasheet again and it requires 1ms delay between turning on/off
> the supply and switching /PD pin (connected to
> OMAP3_PANDORA_DAC_POWER_GPIO). Even though I hear no difference,
> adding the delays back just in case. Updated patch attached.
> _______________________________________________
Btw, have you tried turning the volume to mute when the DAC is enabled.
It may lessen the pop at switch on.
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-02-05 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 13:13 [PATCH -next] ASoC: pandora: Add DAC regulator support Grazvydas Ignotas
2010-02-05 14:08 ` Liam Girdwood
2010-02-05 14:29 ` Grazvydas Ignotas
2010-02-05 15:16 ` Liam Girdwood [this message]
2010-02-05 17:20 ` Mark Brown
2010-02-06 17:33 ` Grazvydas Ignotas
2010-02-07 9:07 ` Jarkko Nikula
2010-02-08 12:29 ` Grazvydas Ignotas
2010-02-08 11:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265383010.3177.13.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).