From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Jarkko Nikula <jhnikula@gmail.com>,
"Candelaria Villareal, Jorge" <jorge.candelaria@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH v3 1/3] ASoC: OMAP: data_type and sync_mode configurable in audio dma
Date: Fri, 19 Feb 2010 14:16:05 +0000 [thread overview]
Message-ID: <1266588965.3236.54.camel@odin> (raw)
In-Reply-To: <20100219160348.ef4a3ce6.jhnikula@gmail.com>
On Fri, 2010-02-19 at 16:03 +0200, Jarkko Nikula wrote:
> On Fri, 19 Feb 2010 10:35:25 +0000
> Liam Girdwood <lrg@slimlogic.co.uk> wrote:
>
> > > @@ -156,11 +158,7 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream)
> > > return 0;
> > >
> > > memset(&dma_params, 0, sizeof(dma_params));
> > > - /*
> > > - * Note: Regardless of interface data formats supported by OMAP McBSP
> > > - * or EAC blocks, internal representation is always fixed 16-bit/sample
> > > - */
> >
> > Perhaps this should be rewritten to reflect mcbsp and mcpdm users rather
> > than deleted.
> >
> I'm fine with the deletion. AFAIK there is no public specs for the EAC
> (at least not for the OMAP2420) so I see this comment only confusing
> (I wrote it) and a person who would write DAI driver for the EAC most
> probably has accesses to the specs.
>
Ok, that's fine.
Jorge, now it's only patch 2/3 requiring a little work.
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-02-19 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 0:32 [PATCH v3 1/3] ASoC: OMAP: data_type and sync_mode configurable in audio dma Candelaria Villareal, Jorge
2010-02-19 10:35 ` Liam Girdwood
2010-02-19 14:03 ` Jarkko Nikula
2010-02-19 14:16 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266588965.3236.54.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
--cc=jorge.candelaria@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox