* [PATCHv4 0/7] TWL6030 audio codec initial support
@ 2010-02-24 0:10 Olaya, Margarita
2010-02-24 11:40 ` Liam Girdwood
0 siblings, 1 reply; 5+ messages in thread
From: Olaya, Margarita @ 2010-02-24 0:10 UTC (permalink / raw)
To: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Cc: broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk
Following patch series add initial support for TWL6030 codec driver.
The patch set is based on the series sent from Misael Lopez in October 2009.
Changes from v3:
- Remove snd_soc_init_card function
- Adapt to latest twl core changes based on Balaji's comment
Regards,
Margarita
---
Misael Lopez Cruz (7):
OMAP4: PMIC: Add support for twl6030 codec
ASoC: TWL6030: Add twl6030 codec driver
ASoC: TWL6030: Manual power-up/down sequences
ASoC: TWL6030: Add support for low-power PLL
ASoC: TWL6030: Add restrictions for low-power playback mode
ASoC: TWL6030: Enable audio interrupt
ASoC: TWL6030: Detect power-up sequence completion
drivers/mfd/twl-core.c | 18 +-
include/linux/i2c/twl.h | 4 +
sound/soc/codecs/Kconfig | 4 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/twl6030.c | 1241 ++++++++++++++++++++++++++++++++++++++++++++
sound/soc/codecs/twl6030.h | 141 +++++
6 files changed, 1407 insertions(+), 3 deletions(-)
create mode 100644 sound/soc/codecs/twl6030.c
create mode 100644 sound/soc/codecs/twl6030.h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv4 0/7] TWL6030 audio codec initial support
2010-02-24 0:10 [PATCHv4 0/7] TWL6030 audio codec initial support Olaya, Margarita
@ 2010-02-24 11:40 ` Liam Girdwood
2010-02-25 0:17 ` Olaya, Margarita
0 siblings, 1 reply; 5+ messages in thread
From: Liam Girdwood @ 2010-02-24 11:40 UTC (permalink / raw)
To: Olaya, Margarita
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
broonie@opensource.wolfsonmicro.com
On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote:
> Following patch series add initial support for TWL6030 codec driver.
> The patch set is based on the series sent from Misael Lopez in October 2009.
>
> Changes from v3:
> - Remove snd_soc_init_card function
> - Adapt to latest twl core changes based on Balaji's comment
>
> Regards,
> Margarita
>
> ---
> Misael Lopez Cruz (7):
> OMAP4: PMIC: Add support for twl6030 codec
> ASoC: TWL6030: Add twl6030 codec driver
> ASoC: TWL6030: Manual power-up/down sequences
> ASoC: TWL6030: Add support for low-power PLL
> ASoC: TWL6030: Add restrictions for low-power playback mode
> ASoC: TWL6030: Enable audio interrupt
> ASoC: TWL6030: Detect power-up sequence completion
Btw, since this is a new driver can you rebase the 6 codec patches into
a single patch.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCHv4 0/7] TWL6030 audio codec initial support
2010-02-24 11:40 ` Liam Girdwood
@ 2010-02-25 0:17 ` Olaya, Margarita
2010-02-25 9:13 ` [alsa-devel] " Liam Girdwood
0 siblings, 1 reply; 5+ messages in thread
From: Olaya, Margarita @ 2010-02-25 0:17 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
broonie@opensource.wolfsonmicro.com
> -----Original Message-----
> From: Liam Girdwood [mailto:lrg@slimlogic.co.uk]
> Sent: Wednesday, February 24, 2010 5:40 AM
> To: Olaya, Margarita
> Cc: alsa-devel@alsa-project.org; linux-omap@vger.kernel.org; broonie@opensource.wolfsonmicro.com
> Subject: Re: [PATCHv4 0/7] TWL6030 audio codec initial support
>
> On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote:
> > Following patch series add initial support for TWL6030 codec driver.
> > The patch set is based on the series sent from Misael Lopez in October 2009.
> >
> > Changes from v3:
> > - Remove snd_soc_init_card function
> > - Adapt to latest twl core changes based on Balaji's comment
> >
> > Regards,
> > Margarita
> >
> > ---
> > Misael Lopez Cruz (7):
> > OMAP4: PMIC: Add support for twl6030 codec
> > ASoC: TWL6030: Add twl6030 codec driver
> > ASoC: TWL6030: Manual power-up/down sequences
> > ASoC: TWL6030: Add support for low-power PLL
> > ASoC: TWL6030: Add restrictions for low-power playback mode
> > ASoC: TWL6030: Enable audio interrupt
> > ASoC: TWL6030: Detect power-up sequence completion
>
> Btw, since this is a new driver can you rebase the 6 codec patches into
> a single patch.
>
The second patch adds the basic support for the codec and the others add features, that way it could be easier to review.
Regards,
Margarita
> Thanks
>
> Liam
>
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCHv4 0/7] TWL6030 audio codec initial support
2010-02-25 0:17 ` Olaya, Margarita
@ 2010-02-25 9:13 ` Liam Girdwood
2010-02-25 17:40 ` Olaya, Margarita
0 siblings, 1 reply; 5+ messages in thread
From: Liam Girdwood @ 2010-02-25 9:13 UTC (permalink / raw)
To: Olaya, Margarita
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
broonie@opensource.wolfsonmicro.com
On Wed, 2010-02-24 at 18:17 -0600, Olaya, Margarita wrote:
>
> > -----Original Message-----
> > From: Liam Girdwood [mailto:lrg@slimlogic.co.uk]
> > Sent: Wednesday, February 24, 2010 5:40 AM
> > To: Olaya, Margarita
> > Cc: alsa-devel@alsa-project.org; linux-omap@vger.kernel.org; broonie@opensource.wolfsonmicro.com
> > Subject: Re: [PATCHv4 0/7] TWL6030 audio codec initial support
> >
> > On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote:
> > > Following patch series add initial support for TWL6030 codec driver.
> > > The patch set is based on the series sent from Misael Lopez in October 2009.
> > >
> > > Changes from v3:
> > > - Remove snd_soc_init_card function
> > > - Adapt to latest twl core changes based on Balaji's comment
> > >
> > > Regards,
> > > Margarita
> > >
> > > ---
> > > Misael Lopez Cruz (7):
> > > OMAP4: PMIC: Add support for twl6030 codec
> > > ASoC: TWL6030: Add twl6030 codec driver
> > > ASoC: TWL6030: Manual power-up/down sequences
> > > ASoC: TWL6030: Add support for low-power PLL
> > > ASoC: TWL6030: Add restrictions for low-power playback mode
> > > ASoC: TWL6030: Enable audio interrupt
> > > ASoC: TWL6030: Detect power-up sequence completion
> >
> > Btw, since this is a new driver can you rebase the 6 codec patches into
> > a single patch.
> >
>
> The second patch adds the basic support for the codec and the others add features, that way it could be easier to review.
Some of the subsequent patches are actually removing chunks of code
rather than just adding new features. In this case it's actually easier
to review the complete codec driver as one patch rather than a series of
changes (showing your internal development history).
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv4 0/7] TWL6030 audio codec initial support
2010-02-25 9:13 ` [alsa-devel] " Liam Girdwood
@ 2010-02-25 17:40 ` Olaya, Margarita
0 siblings, 0 replies; 5+ messages in thread
From: Olaya, Margarita @ 2010-02-25 17:40 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
broonie@opensource.wolfsonmicro.com
> -----Original Message-----
> From: Liam Girdwood [mailto:lrg@slimlogic.co.uk]
> Sent: Thursday, February 25, 2010 3:13 AM
> To: Olaya, Margarita
> Cc: alsa-devel@alsa-project.org; linux-omap@vger.kernel.org; broonie@opensource.wolfsonmicro.com
> Subject: Re: [alsa-devel] [PATCHv4 0/7] TWL6030 audio codec initial support
>
> On Wed, 2010-02-24 at 18:17 -0600, Olaya, Margarita wrote:
> >
> > > -----Original Message-----
> > > From: Liam Girdwood [mailto:lrg@slimlogic.co.uk]
> > > Sent: Wednesday, February 24, 2010 5:40 AM
> > > To: Olaya, Margarita
> > > Cc: alsa-devel@alsa-project.org; linux-omap@vger.kernel.org; broonie@opensource.wolfsonmicro.com
> > > Subject: Re: [PATCHv4 0/7] TWL6030 audio codec initial support
> > >
> > > On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote:
> > > > Following patch series add initial support for TWL6030 codec driver.
> > > > The patch set is based on the series sent from Misael Lopez in October 2009.
> > > >
> > > > Changes from v3:
> > > > - Remove snd_soc_init_card function
> > > > - Adapt to latest twl core changes based on Balaji's comment
> > > >
> > > > Regards,
> > > > Margarita
> > > >
> > > > ---
> > > > Misael Lopez Cruz (7):
> > > > OMAP4: PMIC: Add support for twl6030 codec
> > > > ASoC: TWL6030: Add twl6030 codec driver
> > > > ASoC: TWL6030: Manual power-up/down sequences
> > > > ASoC: TWL6030: Add support for low-power PLL
> > > > ASoC: TWL6030: Add restrictions for low-power playback mode
> > > > ASoC: TWL6030: Enable audio interrupt
> > > > ASoC: TWL6030: Detect power-up sequence completion
> > >
> > > Btw, since this is a new driver can you rebase the 6 codec patches into
> > > a single patch.
> > >
> >
> > The second patch adds the basic support for the codec and the others add features, that way it
> could be easier to review.
>
> Some of the subsequent patches are actually removing chunks of code
> rather than just adding new features. In this case it's actually easier
> to review the complete codec driver as one patch rather than a series of
> changes (showing your internal development history).
>
Ok, I'll send a single patch then.
Regards,
Margarita
> Thanks
>
> Liam
>
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-02-25 17:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-24 0:10 [PATCHv4 0/7] TWL6030 audio codec initial support Olaya, Margarita
2010-02-24 11:40 ` Liam Girdwood
2010-02-25 0:17 ` Olaya, Margarita
2010-02-25 9:13 ` [alsa-devel] " Liam Girdwood
2010-02-25 17:40 ` Olaya, Margarita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).