From: Liam Girdwood <lrg@slimlogic.co.uk>
To: "Olaya, Margarita" <magi.olaya@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [alsa-devel] [PATCHv4 0/7] TWL6030 audio codec initial support
Date: Thu, 25 Feb 2010 09:13:02 +0000 [thread overview]
Message-ID: <1267089182.3255.58.camel@odin> (raw)
In-Reply-To: <1889FA7136B567478A67D4B0F85B0CCE65DD2303@dlee06.ent.ti.com>
On Wed, 2010-02-24 at 18:17 -0600, Olaya, Margarita wrote:
>
> > -----Original Message-----
> > From: Liam Girdwood [mailto:lrg@slimlogic.co.uk]
> > Sent: Wednesday, February 24, 2010 5:40 AM
> > To: Olaya, Margarita
> > Cc: alsa-devel@alsa-project.org; linux-omap@vger.kernel.org; broonie@opensource.wolfsonmicro.com
> > Subject: Re: [PATCHv4 0/7] TWL6030 audio codec initial support
> >
> > On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote:
> > > Following patch series add initial support for TWL6030 codec driver.
> > > The patch set is based on the series sent from Misael Lopez in October 2009.
> > >
> > > Changes from v3:
> > > - Remove snd_soc_init_card function
> > > - Adapt to latest twl core changes based on Balaji's comment
> > >
> > > Regards,
> > > Margarita
> > >
> > > ---
> > > Misael Lopez Cruz (7):
> > > OMAP4: PMIC: Add support for twl6030 codec
> > > ASoC: TWL6030: Add twl6030 codec driver
> > > ASoC: TWL6030: Manual power-up/down sequences
> > > ASoC: TWL6030: Add support for low-power PLL
> > > ASoC: TWL6030: Add restrictions for low-power playback mode
> > > ASoC: TWL6030: Enable audio interrupt
> > > ASoC: TWL6030: Detect power-up sequence completion
> >
> > Btw, since this is a new driver can you rebase the 6 codec patches into
> > a single patch.
> >
>
> The second patch adds the basic support for the codec and the others add features, that way it could be easier to review.
Some of the subsequent patches are actually removing chunks of code
rather than just adding new features. In this case it's actually easier
to review the complete codec driver as one patch rather than a series of
changes (showing your internal development history).
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-02-25 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 0:10 [PATCHv4 0/7] TWL6030 audio codec initial support Olaya, Margarita
2010-02-24 11:40 ` Liam Girdwood
2010-02-25 0:17 ` Olaya, Margarita
2010-02-25 9:13 ` Liam Girdwood [this message]
2010-02-25 17:40 ` Olaya, Margarita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267089182.3255.58.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=magi.olaya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).