alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: bf5xx-sport: use common SPORT code for MMR info
@ 2010-03-09 17:58 Mike Frysinger
  2010-03-09 20:50 ` Liam Girdwood
  2010-03-10 12:00 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Mike Frysinger @ 2010-03-09 17:58 UTC (permalink / raw)
  To: alsa-devel, Mark Brown; +Cc: Barry Song

From: Barry Song <barry.song@analog.com>

No point in duplicating this structure layout in each driver.

Signed-off-by: Barry Song <barry.song@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
this is fine for 2.6.34 or 2.6.35

 sound/soc/blackfin/bf5xx-sport.h |   28 +---------------------------
 1 files changed, 1 insertions(+), 27 deletions(-)

diff --git a/sound/soc/blackfin/bf5xx-sport.h b/sound/soc/blackfin/bf5xx-sport.h
index 2e63dea..a86e8cc 100644
--- a/sound/soc/blackfin/bf5xx-sport.h
+++ b/sound/soc/blackfin/bf5xx-sport.h
@@ -34,33 +34,7 @@
 #include <linux/wait.h>
 #include <linux/workqueue.h>
 #include <asm/dma.h>
-
-struct sport_register {
-	u16 tcr1;	u16 reserved0;
-	u16 tcr2;	u16 reserved1;
-	u16 tclkdiv;	u16 reserved2;
-	u16 tfsdiv;	u16 reserved3;
-	u32 tx;
-	u32 reserved_l0;
-	u32 rx;
-	u32 reserved_l1;
-	u16 rcr1;	u16 reserved4;
-	u16 rcr2;	u16 reserved5;
-	u16 rclkdiv;	u16 reserved6;
-	u16 rfsdiv;	u16 reserved7;
-	u16 stat;	u16 reserved8;
-	u16 chnl;	u16 reserved9;
-	u16 mcmc1;	u16 reserved10;
-	u16 mcmc2;	u16 reserved11;
-	u32 mtcs0;
-	u32 mtcs1;
-	u32 mtcs2;
-	u32 mtcs3;
-	u32 mrcs0;
-	u32 mrcs1;
-	u32 mrcs2;
-	u32 mrcs3;
-};
+#include <asm/bfin_sport.h>
 
 #define DESC_ELEMENT_COUNT 9
 
-- 
1.7.0.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: bf5xx-sport: use common SPORT code for MMR info
  2010-03-09 17:58 [PATCH] ASoC: bf5xx-sport: use common SPORT code for MMR info Mike Frysinger
@ 2010-03-09 20:50 ` Liam Girdwood
  2010-03-10 12:00 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-03-09 20:50 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: alsa-devel, Mark Brown, Barry Song

On Tue, 2010-03-09 at 12:58 -0500, Mike Frysinger wrote:
> From: Barry Song <barry.song@analog.com>
> 
> No point in duplicating this structure layout in each driver.
> 
> Signed-off-by: Barry Song <barry.song@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: bf5xx-sport: use common SPORT code for MMR info
  2010-03-09 17:58 [PATCH] ASoC: bf5xx-sport: use common SPORT code for MMR info Mike Frysinger
  2010-03-09 20:50 ` Liam Girdwood
@ 2010-03-10 12:00 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-03-10 12:00 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: alsa-devel, Barry Song

On Tue, Mar 09, 2010 at 12:58:14PM -0500, Mike Frysinger wrote:
> From: Barry Song <barry.song@analog.com>
> 
> No point in duplicating this structure layout in each driver.
> 
> Signed-off-by: Barry Song <barry.song@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-03-10 12:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-09 17:58 [PATCH] ASoC: bf5xx-sport: use common SPORT code for MMR info Mike Frysinger
2010-03-09 20:50 ` Liam Girdwood
2010-03-10 12:00 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).