From: Liam Girdwood <lrg@slimlogic.co.uk>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
Jassi Brar <jassi.brar@samsung.com>,
ben-linux@fluff.org
Subject: Re: Reforming S3C I2S towards supporting I2Sv4
Date: Wed, 10 Mar 2010 09:04:07 +0000 [thread overview]
Message-ID: <1268211847.3760.23.camel@odin> (raw)
In-Reply-To: <1b68c6791003100031m7be14ecr218e4f988bd30cab@mail.gmail.com>
On Wed, 2010-03-10 at 17:31 +0900, jassi brar wrote:
> On Wed, Mar 10, 2010 at 5:24 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> > On Wed, 2010-03-10 at 16:48 +0900, Jassi Brar wrote:
> >> The header with I2S register map and bit definitions has been copied
> >> to where the drivers are(sound/soc/s3c24xx/) since the header has nothing
> >> usable for platform code. Also, it will help avoid need for co-ordination
> >> between ASoC and S3C ARCH trees. For now, the header regs-s3c2412-iis.h
> >> is left intact but rendered useless by making ASoC drivers include the
> >> newly copied version of it (sound/soc/s3c24xx/regs-i2s-v2.h) Later the
> >> header could be dropped by patches to S3C PLAT tree.
> >>
> >
> > I'm not too keen on moving CPU register and bit definitions out of ARCH.
> The header doesn't contain absolute register addresses, but only
> offsets.
Isn't this really the same thing ?
> The base address of I2S controllers are defined in PLAT
> specific header. So, I think we can move the header.
I don't think your reason of "co-ordination between ASoC and S3C ARCH
trees" can justify breaking kernel policy.
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-03-10 9:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 7:48 Reforming S3C I2S towards supporting I2Sv4 Jassi Brar
2010-03-10 8:24 ` Liam Girdwood
2010-03-10 8:31 ` jassi brar
2010-03-10 9:04 ` Liam Girdwood [this message]
2010-03-10 9:22 ` jassi brar
2010-03-10 10:18 ` Mark Brown
2010-03-10 8:35 ` jassi brar
2010-03-10 8:51 ` Liam Girdwood
2010-03-10 9:02 ` jassi brar
2010-03-10 10:20 ` Mark Brown
2010-03-10 14:23 ` Mark Brown
2010-04-06 0:33 ` jassi brar
2010-04-27 2:10 ` jassi brar
2010-04-27 2:58 ` Ben Dooks
2010-04-27 4:25 ` jassi brar
2010-05-02 4:38 ` Kyungmin Park
2010-05-02 8:28 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268211847.3760.23.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).