alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: alsa-devel@alsa-project.org
Subject: Re: aconnect patch
Date: Mon, 15 Mar 2010 15:32:25 +0100	[thread overview]
Message-ID: <1268663545.9635.10.camel@mattotaupa> (raw)
In-Reply-To: <4B9E306F.8070705@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1067 bytes --]

Dear lieven,


Am Montag, den 15.03.2010, 14:04 +0100 schrieb lieven moors:

[…]

> Please let me know what you think about this patch, and if you think my reasoning is sane...

thank you for your work. Unfortunately your MUA mangled the output.
Could you please resend without linebreaks.

It looks like you used `git format-patch` already. Great! You can also
use `git send-email` if you plan on submitting more patches [1].

Anyway, could you also add a `Signed-off-by` line (`git commit -s` or
`git format-patch -s`) and add a more descriptive summary as `aconnect
-x: Do not update index after removal of connection.`. (This is just
taken form your summary.)

Please make sure when resending to not this by »[PATCH v2]« in front of
your subject line, e. g. `git format-patch --subject-prefix="Patch v2"`
(see `git help format-patch`).


Thanks again and sorry for the long response,

Paul


[1] http://git.wiki.kernel.org/index.php/GitTips#Using_gmail_to_send_your_patches
[2] http://elinux.org/Git_usage#Sending_with_Gmail


[-- Attachment #1.2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2010-03-15 14:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 13:04 aconnect patch lieven moors
2010-03-15 14:32 ` Paul Menzel [this message]
2010-03-15 17:40   ` lieven moors
2010-03-15 20:47     ` [Patch v2] aconnect -x: Do not update index after removal of connection Paul Menzel
2010-03-15 22:30       ` lieven moors
2010-03-24 15:32         ` lieven moors
2010-03-25 10:05           ` Paul Menzel
2010-03-25 11:23             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268663545.9635.10.camel@mattotaupa \
    --to=paulepanter@users.sourceforge.net \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).