From: Barry Song <21cnbao@gmail.com>
To: broonie@opensource.wolfsonmicro.com
Cc: uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org, Barry Song <21cnbao@gmail.com>,
Barry Song <barry.song@analog.com>
Subject: [PATCH 4/4] soc-cache: let reg be AND'ed by 0xff instead of data buffer for 8_8 mode
Date: Thu, 18 Mar 2010 16:17:01 +0800 [thread overview]
Message-ID: <1268900221-6833-5-git-send-email-21cnbao@gmail.com> (raw)
In-Reply-To: <1268900221-6833-4-git-send-email-21cnbao@gmail.com>
The registers for AD193X are defined as 0x800-0x810 for spi which uses 16_8 mode,
for i2c to support AD1937, we will use 8_8 mode, only the low byte of 0x800-0x810
is valid.
The patch will not destory other codecs, but make soc cache interface more useful.
Signed-off-by: Barry Song <barry.song@analog.com>
---
sound/soc/soc-cache.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
index 91db7af..9dfe9a5 100644
--- a/sound/soc/soc-cache.c
+++ b/sound/soc/soc-cache.c
@@ -159,7 +159,8 @@ static int snd_soc_8_8_write(struct snd_soc_codec *codec, unsigned int reg,
BUG_ON(codec->volatile_register);
- data[0] = reg & 0xff;
+ reg &= 0xff;
+ data[0] = reg;
data[1] = value & 0xff;
if (reg < codec->reg_cache_size)
@@ -180,6 +181,7 @@ static unsigned int snd_soc_8_8_read(struct snd_soc_codec *codec,
unsigned int reg)
{
u8 *cache = codec->reg_cache;
+ reg &= 0xff;
if (reg >= codec->reg_cache_size)
return -1;
return cache[reg];
--
1.5.6.3
next prev parent reply other threads:[~2010-03-18 8:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 8:16 [PATCH 0/4] extend ad1938 codec/machine driver to ad193x supporting ad1936/7/8/9 Barry Song
[not found] ` <1268900221-6833-1-git-send-email-21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-03-18 8:16 ` [PATCH 1/4] extend ad1938 codec " Barry Song
[not found] ` <1268900221-6833-2-git-send-email-21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-03-18 8:16 ` [PATCH 2/4] change bf5xx-ad1938 machine driver to bf5xx-ad193x machine driver Barry Song
[not found] ` <1268900221-6833-3-git-send-email-21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-03-18 8:17 ` [PATCH 3/4] soc-cache: add i2c read entry for 8_8 mode Barry Song
2010-03-18 8:17 ` Barry Song [this message]
2010-03-18 9:00 ` [PATCH 4/4] soc-cache: let reg be AND'ed by 0xff instead of data buffer " Liam Girdwood
2010-03-18 11:30 ` Mark Brown
2010-03-18 8:51 ` [PATCH 3/4] soc-cache: add i2c read entry " Liam Girdwood
2010-03-18 11:29 ` Mark Brown
2010-03-18 11:22 ` [PATCH 2/4] change bf5xx-ad1938 machine driver to bf5xx-ad193x machine driver Mark Brown
2010-03-18 8:48 ` [PATCH 1/4] extend ad1938 codec driver to ad193x supporting ad1936/7/8/9 Liam Girdwood
2010-03-18 9:08 ` Barry Song
2010-03-18 11:18 ` Mark Brown
2010-03-18 15:57 ` [Uclinux-dist-devel] " Mike Frysinger
2010-03-18 16:20 ` Mark Brown
2010-03-18 17:17 ` Mike Frysinger
2010-03-18 18:05 ` Mark Brown
2010-03-18 18:08 ` Mike Frysinger
2010-03-19 3:30 ` Barry Song
2010-03-19 7:07 ` Barry Song
2010-03-19 9:03 ` Liam Girdwood
2010-03-19 12:24 ` Mark Brown
2010-03-22 5:50 ` Barry Song
2010-03-22 12:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268900221-6833-5-git-send-email-21cnbao@gmail.com \
--to=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=barry.song@analog.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).