From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: [PATCH] ASoC: TWL4030: PM fix for output amplifiers
Date: Mon, 22 Mar 2010 16:48:34 +0000 [thread overview]
Message-ID: <1269276514.3754.21.camel@odin> (raw)
In-Reply-To: <20100322161928.GA30295@rakim.wolfsonmicro.main>
On Mon, 2010-03-22 at 16:19 +0000, Mark Brown wrote:
> On Mon, Mar 22, 2010 at 05:31:14PM +0200, Peter Ujfalusi wrote:
>
> > How I see this: we can go and introduce new controls, DAPM widgets for all type
> > just for the sake of the TWL codec. But at the end it will be still TWL
> > specific.
>
> > I'm not saying that other codecs could not use some generic way (in a way, that
> > you have described) to make their amps muted when they are not needed.
> > What I'm saying, is that I don't see a generic way which can handle the TWL
> > codec.
>
> Could you please be more specific about what you believe is going on
> with TWL4030 here? It would really help if you could be more specific
> about how you see the register cache getting updated.
I think Peter means that without making changes to the current IO model
or reverting the removal of the old PGA code there is no generic way of
handling this atm.
So we should probably look at bringing back the PGA code (now that there
is a user) so that the patch can be updated to use it.
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-03-22 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 13:36 [PATCH] ASoC: TWL4030: PM fix for output amplifiers Peter Ujfalusi
2010-03-22 13:47 ` Mark Brown
2010-03-22 14:04 ` Peter Ujfalusi
2010-03-22 14:15 ` Mark Brown
2010-03-22 14:46 ` Peter Ujfalusi
2010-03-22 15:06 ` Mark Brown
2010-03-22 15:31 ` Peter Ujfalusi
2010-03-22 16:19 ` Mark Brown
2010-03-22 16:48 ` Liam Girdwood [this message]
2010-03-22 17:00 ` Mark Brown
2010-03-23 7:05 ` Peter Ujfalusi
2010-03-23 7:59 ` Peter Ujfalusi
2010-03-23 10:02 ` Mark Brown
2010-03-23 12:29 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269276514.3754.21.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).