* [PATCH 10/16] ASoC: wm2000: remove unused #include <linux/version.h>
@ 2010-04-08 11:50 Huang Weiyi
2010-04-08 13:34 ` Liam Girdwood
2010-04-08 14:19 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Huang Weiyi @ 2010-04-08 11:50 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, Huang Weiyi
Remove unused #include <linux/version.h>('s) in
sound/soc/codecs/wm2000.c
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
---
sound/soc/codecs/wm2000.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm2000.c b/sound/soc/codecs/wm2000.c
index a34cbcf..002e289 100644
--- a/sound/soc/codecs/wm2000.c
+++ b/sound/soc/codecs/wm2000.c
@@ -23,7 +23,6 @@
#include <linux/module.h>
#include <linux/moduleparam.h>
-#include <linux/version.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/firmware.h>
--
1.6.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 10/16] ASoC: wm2000: remove unused #include <linux/version.h>
2010-04-08 11:50 [PATCH 10/16] ASoC: wm2000: remove unused #include <linux/version.h> Huang Weiyi
@ 2010-04-08 13:34 ` Liam Girdwood
2010-04-08 14:19 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-04-08 13:34 UTC (permalink / raw)
To: Huang Weiyi; +Cc: alsa-devel, broonie
On Thu, 2010-04-08 at 19:50 +0800, Huang Weiyi wrote:
> Remove unused #include <linux/version.h>('s) in
> sound/soc/codecs/wm2000.c
>
> Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 10/16] ASoC: wm2000: remove unused #include <linux/version.h>
2010-04-08 11:50 [PATCH 10/16] ASoC: wm2000: remove unused #include <linux/version.h> Huang Weiyi
2010-04-08 13:34 ` Liam Girdwood
@ 2010-04-08 14:19 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-04-08 14:19 UTC (permalink / raw)
To: Huang Weiyi; +Cc: alsa-devel
On Thu, Apr 08, 2010 at 07:50:08PM +0800, Huang Weiyi wrote:
> Remove unused #include <linux/version.h>('s) in
> sound/soc/codecs/wm2000.c
>
> Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Applied. Rather than continually posting these patches it would seem a
lot better if you were to instead patch checkpatch.pl to warn on use of
this header. There's no reason to use it in the bulk of kernel code and
it'd be a lot less work to catch these things automatically.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-08 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-08 11:50 [PATCH 10/16] ASoC: wm2000: remove unused #include <linux/version.h> Huang Weiyi
2010-04-08 13:34 ` Liam Girdwood
2010-04-08 14:19 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).