Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: anish.singh@samsung.com
Cc: "liam.girdwood@wolfsonmicro.com" <liam.girdwood@wolfsonmicro.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"broonie@opensource.wolfsonmicro.com"
	<broonie@opensource.wolfsonmicro.com>
Subject: Re: No shutdown code in soc-core.c
Date: Fri, 16 Apr 2010 18:21:30 +0100	[thread overview]
Message-ID: <1271438490.3235.33.camel@odin> (raw)
In-Reply-To: <17476636.107751271436284230.JavaMail.weblogic@epml11>

On Fri, 2010-04-16 at 16:44 +0000, ANISH KUMAR wrote:
> >What are you trying to do ?
>  
> There was a "TAK" noise because of non-presence of this code.
> This soc_shutdown calls the respective shutdown code in codec
> for prevention of this kind of strange noise.In my code it is turning
> off the Amplifier because of which i no longer get the "TAK" sound.
> 

Ok, so afaict you hear a "TAK" noise at stream shutdown and want to get
rid of it. ASoC calls shutdown/close for each of it's components :-

	if (cpu_dai->ops->shutdown)
		cpu_dai->ops->shutdown(substream, cpu_dai);

	if (codec_dai->ops->shutdown)
		codec_dai->ops->shutdown(substream, codec_dai);

	if (machine->ops && machine->ops->shutdown)
		machine->ops->shutdown(substream);

	if (platform->pcm_ops->close)
		platform->pcm_ops->close(substream);

> So i am just wondering why this code is not present in the struct 
> i mentioned in my previous mail.

You didn't mention any struct in your last mail.

Please explain your problems more clearly in the future. It's very
difficult to help here without a good problem description or a detailed
explanation of why you need this feature.

Liam

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-04-16 17:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-16 16:44 No shutdown code in soc-core.c ANISH KUMAR
2010-04-16 17:21 ` Liam Girdwood [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-04-22  8:10 ANISH KUMAR
2010-04-19 13:19 ANISH KUMAR
2010-04-19 14:10 ` Liam Girdwood
2010-04-19 16:59   ` Mark Brown
2010-04-17  7:02 ANISH KUMAR
2010-04-19 12:15 ` Liam Girdwood
2010-04-16  2:29 ANISH KUMAR
2010-04-16 16:03 ` Liam Girdwood
2010-04-16 18:47 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271438490.3235.33.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=anish.singh@samsung.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=liam.girdwood@wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox