From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: core: Fix for the volume limiting when invert is in use
Date: Mon, 10 May 2010 19:56:22 +0100 [thread overview]
Message-ID: <1273517782.3288.130.camel@odin> (raw)
In-Reply-To: <1273491564-11666-1-git-send-email-peter.ujfalusi@nokia.com>
On Mon, 2010-05-10 at 14:39 +0300, Peter Ujfalusi wrote:
> If the register for the volume needs invert, than the inversion
> need to be done from the chip maximum, and not from the platform
> dependent limit.
> Introduce soc_mixer_control.platform_max value, which initially
> equals to chip maximum.
> The snd_soc_limit_volume function only modify the platform_max,
> all volsw_info call returns this as well.
> The .max value holds the chip default (maximum), and it is used
> for the inversion, if it is needed.
>
> Additional check in the volsw_info call has been added to check
> the validity of the platform_max in case, when custom macros
> used by codec drivers are not initializing it correctly.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-05-10 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 11:39 [PATCH] ASoC: core: Fix for the volume limiting when invert is in use Peter Ujfalusi
2010-05-10 18:56 ` Liam Girdwood [this message]
2010-05-11 8:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273517782.3288.130.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).