[PATCH] ALSA: usb/mixer.c: remove unused variable

[PATCH] ALSA: usb/mixer.c: remove unused variable

[Daniel Mack]

This was a development left-over.

Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Clemens Ladisch <clemens@ladisch.de>
---
 sound/usb/mixer.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index fd3e08d..a35dd74 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -1970,8 +1970,6 @@ static void snd_usb_mixer_proc_read(struct snd_info_entry *entry,
 static void snd_usb_mixer_interrupt_v2(struct usb_mixer_interface *mixer,
 				       int attribute, int value, int index)
 {
-	struct usb_mixer_elem_info *info;
-
 	switch (attribute) {
 	case UAC2_CS_CUR:
 		snd_usb_mixer_notify_id(mixer, index);
-- 
1.7.1

Re: [PATCH] ALSA: usb/mixer.c: remove unused variable

[Takashi Iwai]

At Wed, 19 May 2010 17:34:45 +0200,
Daniel Mack wrote:
> 
> This was a development left-over.
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Clemens Ladisch <clemens@ladisch.de>

This can't be applied to the latest tree.  Missing patches?


Takashi

> ---
>  sound/usb/mixer.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> index fd3e08d..a35dd74 100644
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -1970,8 +1970,6 @@ static void snd_usb_mixer_proc_read(struct snd_info_entry *entry,
>  static void snd_usb_mixer_interrupt_v2(struct usb_mixer_interface *mixer,
>  				       int attribute, int value, int index)
>  {
> -	struct usb_mixer_elem_info *info;
> -
>  	switch (attribute) {
>  	case UAC2_CS_CUR:
>  		snd_usb_mixer_notify_id(mixer, index);
> -- 
> 1.7.1
> 

Re: [PATCH] ALSA: usb/mixer.c: remove unused variable

[Daniel Mack]

On Wed, May 19, 2010 at 06:29:45PM +0200, Takashi Iwai wrote:
> At Wed, 19 May 2010 17:34:45 +0200,
> Daniel Mack wrote:
> > 
> > This was a development left-over.
> > 
> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Cc: Clemens Ladisch <clemens@ladisch.de>
> 
> This can't be applied to the latest tree.  Missing patches?

Gna, I've been working on a wrong branch, sorry. Please drop this patch.

Daniel

Re: Mute LED on HP Pavilion DV7-1160eg

[Thoralf Freitag]

Hi Takashi,

since you have patched the source code for the control of the Mute LED
on HP Pavilion DV7, I could test it for a longer time.

Everything works fine - except shutdown of the computer. I found out,
during the shutdown process a short loud hum occurs. This hum is
independ of volume and it come also, if sound muted.

I don't know whether this nomal (expected) or anything else is not 100 %
OK. What's your opinion ?


Thoralf