From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 5/7] ASoC: TWL4030: Helper to check chip default registers
Date: Tue, 25 May 2010 14:09:56 +0100 [thread overview]
Message-ID: <1274792996.3000.233.camel@odin> (raw)
In-Reply-To: <201005251520.40206.peter.ujfalusi@nokia.com>
On Tue, 2010-05-25 at 15:20 +0300, Peter Ujfalusi wrote:
> >
> > Is this purely for information/debug purposes ?
>
> Yes, the driver support twl4030, twl5030, twl5031, tps*something* chips.
> If someone, who have access to those chips, and in doubt, can check it.
>
So it's more a debug aid.
> > Why do we need to check default vales at init(). Is there another driver
> > changing the audio codec registers ?
>
> This driver is going to change it.
> It is also possible that the bootloader changed them (startup tone?).
Yeah, that's what I thought. In the past I've always forced the CODEC
registers to their default values during probe(). Very handy if the
driver is a module and you are recovering from a buggy state.
> So it is not really bulletproof, but at least it helped me to find out the the
> ARXR2_APGA_CTL register does not have the reset value, which it supposed to
> have.
>
> Well, I can remove it, but I thought that it is a nice touch ;)
>
It's nice ;) But maybe we should reset the default values at probe() to
be sure.
Thanks
Liam
next prev parent reply other threads:[~2010-05-25 13:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 11:34 [PATCH 0/7] ASoC: TWL4030: put the codec to off when not active Peter Ujfalusi
2010-05-25 11:34 ` [PATCH 1/7] ASoC: TWL4030: Revisit codec defaults Peter Ujfalusi
2010-05-25 11:34 ` [PATCH 2/7] ASoC: TWL4030: Remove wrapper for power down Peter Ujfalusi
2010-05-25 11:34 ` [PATCH 3/7] ASoC: TWL4030: Make offset cancellation path configurable Peter Ujfalusi
2010-05-25 11:59 ` Peter Ujfalusi
2010-05-25 11:34 ` [PATCH 4/7] ASoC: TWL4030: Optimize the power up sequence Peter Ujfalusi
2010-05-25 11:34 ` [PATCH 5/7] ASoC: TWL4030: Helper to check chip default registers Peter Ujfalusi
2010-05-25 11:57 ` Liam Girdwood
2010-05-25 12:20 ` Peter Ujfalusi
2010-05-25 13:09 ` Liam Girdwood [this message]
2010-05-26 6:00 ` Peter Ujfalusi
2010-05-26 6:28 ` Peter Ujfalusi
2010-05-26 6:35 ` Mark Brown
2010-05-26 7:15 ` Peter Ujfalusi
2010-05-25 11:34 ` [PATCH 6/7] ASoC: TWL4030: Correct the ARXR2_APGA_CTL chip default Peter Ujfalusi
2010-05-25 11:34 ` [PATCH 7/7] ASoC: TWL4030: Use BIAS_OFF instead of BIAS_STANDBY, when not in use Peter Ujfalusi
2010-05-25 17:35 ` [PATCH 0/7] ASoC: TWL4030: put the codec to off when not active Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274792996.3000.233.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).