From: Jerone Young <jerone.young@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Andreas Herrmann <herrmann.der.user@googlemail.com>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH] ALSA, hda: Add support for Lenovo ThinkPad Edge 13 in conexant codec
Date: Fri, 28 May 2010 01:02:09 -0500 [thread overview]
Message-ID: <1275026529.2945.1701.camel@laptop> (raw)
In-Reply-To: <s5htyps3788.wl%tiwai@suse.de>
@Andreas
can you grab Alsa git tree and install it on the system you are using.
It has a patch already taking care of the issue.
The issue Takashi is most likely folks using the older kernel version.
model=ideapad was just recently introduced so they where unable to try
that out. But olpc-xo-1_5 has been there for a while. Though for Lenovo
products model=ideapad is much better.
Thanks,
Jerone
On Fri, 2010-05-28 at 07:50 +0200, Takashi Iwai wrote:
> At Thu, 27 May 2010 18:06:56 +0200,
> Andreas Herrmann wrote:
> >
> > From: Andreas Herrmann <andreas.herrmann3@amd.com>
> >
> > On a Thinkpad Edge 13 I had the problem that speakers played sound
> > although headphones were plugged.
> >
> > Using "model=olpc-xo-1_5" solved this problem. So it seems sensible to
> > add this quirk. (Using other models, like ideabad did not fix it.)
> >
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> > ---
> > sound/pci/hda/patch_conexant.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > I don't know whether adding this quirk is the right/complete solution
> > to support sound on Thinkpad Edge. But at least it solves this
> > annoying problem.
>
> Well, Jerone Young already sent a quirk patch but he took
> model=ideapd. Could you guys check which one is really better?
>
>
> thanks,
>
> Takashi
>
>
> >
> > Please apply.
> >
> >
> > Thanks,
> >
> > Andreas
> >
> > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> > index feabb44..f85f072 100644
> > --- a/sound/pci/hda/patch_conexant.c
> > +++ b/sound/pci/hda/patch_conexant.c
> > @@ -2848,6 +2848,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
> > SND_PCI_QUIRK(0x1179, 0xff50, "Toshiba Satellite P500-PSPGSC-01800T", CXT5066_OLPC_XO_1_5),
> > SND_PCI_QUIRK(0x1179, 0xffe0, "Toshiba Satellite Pro T130-15F", CXT5066_OLPC_XO_1_5),
> > SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),
> > + SND_PCI_QUIRK(0x17aa, 0x21b3, "Thnkpad Edge 13", CXT5066_OLPC_XO_1_5),
> > SND_PCI_QUIRK(0x17aa, 0x3a0d, "ideapad", CXT5066_IDEAPAD),
> > {}
> > };
> > --
> > 1.6.4.4
> >
next prev parent reply other threads:[~2010-05-28 6:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100527160656.GE10254@alberich.amd.com>
2010-05-28 5:50 ` [PATCH] ALSA, hda: Add support for Lenovo ThinkPad Edge 13 in conexant codec Takashi Iwai
2010-05-28 6:02 ` Jerone Young [this message]
2010-05-28 6:21 ` Andreas Herrmann
2010-05-28 6:35 ` Jerone Young
2010-05-28 6:45 ` Andreas Herrmann
2010-05-28 7:57 ` [PATCH] ALSA, hda: Add support for another Lenovo ThinkPad Edge " Andreas Herrmann
2010-05-28 8:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275026529.2945.1701.camel@laptop \
--to=jerone.young@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=borislav.petkov@amd.com \
--cc=herrmann.der.user@googlemail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).