From: Mark Hills <mark@pogo.org.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: [PATCH 2/4] snd-usb-caiaq: Simplify single case to an 'if'
Date: Sat, 29 May 2010 16:53:24 +0100 [thread overview]
Message-ID: <1275148406-24596-2-git-send-email-mark@pogo.org.uk> (raw)
In-Reply-To: <1275148406-24596-1-git-send-email-mark@pogo.org.uk>
After removing code, only one case remains. So use an 'if' instead.
Acked-by: Daniel Mack <daniel@caiaq.de>
Signed-off-by: Mark Hills <mark@pogo.org.uk>
---
sound/usb/caiaq/control.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/usb/caiaq/control.c b/sound/usb/caiaq/control.c
index 70c3866..91c804c 100644
--- a/sound/usb/caiaq/control.c
+++ b/sound/usb/caiaq/control.c
@@ -95,11 +95,9 @@ static int control_put(struct snd_kcontrol *kcontrol,
int pos = kcontrol->private_value;
unsigned char cmd = EP1_CMD_WRITE_IO;
- switch (dev->chip.usb_id) {
- case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_TRAKTORKONTROLX1):
+ if (dev->chip.usb_id ==
+ USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_TRAKTORKONTROLX1))
cmd = EP1_CMD_DIMM_LEDS;
- break;
- }
if (pos & CNT_INTVAL) {
dev->control_state[pos & ~CNT_INTVAL]
--
1.7.1
next prev parent reply other threads:[~2010-05-29 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 15:53 [PATCH 1/4] snd-usb-caiaq: Restore 'Control vinyl' input mode on A4DJ Mark Hills
2010-05-29 15:53 ` Mark Hills [this message]
2010-05-29 15:53 ` [PATCH 3/4] Revert "ALSA: snd-usb-caiaq: Set default input mode of A4DJ" Mark Hills
2010-05-29 15:53 ` [PATCH 4/4] snd-usb-caiaq: Bump version number to 1.3.21 Mark Hills
2010-05-31 7:20 ` [PATCH 1/4] snd-usb-caiaq: Restore 'Control vinyl' input mode on A4DJ Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275148406-24596-2-git-send-email-mark@pogo.org.uk \
--to=mark@pogo.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).