From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal
Date: Wed, 02 Jun 2010 10:43:07 +0100 [thread overview]
Message-ID: <1275471787.3037.28.camel@odin> (raw)
In-Reply-To: <4C05F211.7070308@gmail.com>
On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
> This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
>
> There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
> the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
> judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
> than 'if (PCM_TX == stype)', which makes the codes easy to read.
>
> Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>
All
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-06-02 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C05F211.7070308@gmail.com>
2010-06-02 6:07 ` [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal Wan ZongShun
2010-06-02 9:43 ` Liam Girdwood [this message]
2010-06-02 10:40 ` Mark Brown
2010-06-02 10:44 ` Wan ZongShun
2010-06-05 7:08 ` Wan ZongShun
2010-06-07 13:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275471787.3037.28.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=mcuos.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).