* Re: [PATCH] sound/spi: patch for the unuseful variable removal [not found] <4C08B9A0.5000408@gmail.com> @ 2010-06-07 12:52 ` Liam Girdwood 2010-06-07 13:01 ` Mark Brown 1 sibling, 0 replies; 4+ messages in thread From: Liam Girdwood @ 2010-06-07 12:52 UTC (permalink / raw) To: Wan ZongShun; +Cc: alsa-devel, Mark Brown On Fri, 2010-06-04 at 16:30 +0800, Wan ZongShun wrote: > The '*bitclk' of structure 'snd_at73c213' seems no use > ,so I make a patch to remove the unnecessary variable. > > Signed-off-by: Wan ZongShun <mcuos.com@gmail.com> > --- > sound/spi/at73c213.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/sound/spi/at73c213.c b/sound/spi/at73c213.c > index 4c7b051..1bc56b2 100644 > --- a/sound/spi/at73c213.c > +++ b/sound/spi/at73c213.c > @@ -69,7 +69,6 @@ struct snd_at73c213 { > int irq; > int period; > unsigned long bitrate; > - struct clk *bitclk; > struct ssc_device *ssc; > struct spi_device *spi; > u8 spi_wbuffer[2]; Acked-by: Liam Girdwood <lrg@slimlogic.co.uk> -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sound/spi: patch for the unuseful variable removal [not found] <4C08B9A0.5000408@gmail.com> 2010-06-07 12:52 ` [PATCH] sound/spi: patch for the unuseful variable removal Liam Girdwood @ 2010-06-07 13:01 ` Mark Brown 2010-06-08 14:58 ` Takashi Iwai 1 sibling, 1 reply; 4+ messages in thread From: Mark Brown @ 2010-06-07 13:01 UTC (permalink / raw) To: Wan ZongShun; +Cc: alsa-devel, Liam Girdwood On Fri, Jun 04, 2010 at 04:30:24PM +0800, Wan ZongShun wrote: > The '*bitclk' of structure 'snd_at73c213' seems no use > ,so I make a patch to remove the unnecessary variable. > > Signed-off-by: Wan ZongShun <mcuos.com@gmail.com> We should probably just remove this driver, it should be done within ASoC rather than like this. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sound/spi: patch for the unuseful variable removal 2010-06-07 13:01 ` Mark Brown @ 2010-06-08 14:58 ` Takashi Iwai 2010-06-08 15:06 ` Mark Brown 0 siblings, 1 reply; 4+ messages in thread From: Takashi Iwai @ 2010-06-08 14:58 UTC (permalink / raw) To: Mark Brown; +Cc: alsa-devel, Wan ZongShun, Liam Girdwood At Mon, 7 Jun 2010 14:01:13 +0100, Mark Brown wrote: > > On Fri, Jun 04, 2010 at 04:30:24PM +0800, Wan ZongShun wrote: > > The '*bitclk' of structure 'snd_at73c213' seems no use > > ,so I make a patch to remove the unnecessary variable. > > > > Signed-off-by: Wan ZongShun <mcuos.com@gmail.com> > > We should probably just remove this driver, it should be done within > ASoC rather than like this. In that case, we should put the driver first as deprecated and give some removal schedule. Anyway, I applied the patch now with Liam's ack. thanks, Takashi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sound/spi: patch for the unuseful variable removal 2010-06-08 14:58 ` Takashi Iwai @ 2010-06-08 15:06 ` Mark Brown 0 siblings, 0 replies; 4+ messages in thread From: Mark Brown @ 2010-06-08 15:06 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel, Wan ZongShun, Liam Girdwood On Tue, Jun 08, 2010 at 04:58:05PM +0200, Takashi Iwai wrote: > Anyway, I applied the patch now with Liam's ack. OK - feel free to add mine also. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-08 15:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4C08B9A0.5000408@gmail.com>
2010-06-07 12:52 ` [PATCH] sound/spi: patch for the unuseful variable removal Liam Girdwood
2010-06-07 13:01 ` Mark Brown
2010-06-08 14:58 ` Takashi Iwai
2010-06-08 15:06 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).