From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH v2 4/4]AsoC/nuc900: fix a typo and rename the header file
Date: Wed, 09 Jun 2010 14:33:49 +0100 [thread overview]
Message-ID: <1276090429.3067.15.camel@odin> (raw)
In-Reply-To: <4C05F49A.8070309@gmail.com>
On Wed, 2010-06-02 at 14:05 +0800, Wan ZongShun wrote:
> Fix a '#include "nuc900-audio.h' typo, I think it should be 'audio'.
> At the same time, this patch renames the 'nuc900-auido.h' file to
> 'nuc900-audio.h'.
>
> Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>
> ---
> sound/soc/nuc900/nuc900-ac97.c | 2 +-
> .../soc/nuc900/{nuc900-auido.h => nuc900-audio.h} | 0
> 2 files changed, 1 insertions(+), 1 deletions(-)
> rename sound/soc/nuc900/{nuc900-auido.h => nuc900-audio.h} (100%)
>
> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
> index db7fc13..caa7c90 100644
> --- a/sound/soc/nuc900/nuc900-ac97.c
> +++ b/sound/soc/nuc900/nuc900-ac97.c
> @@ -25,7 +25,7 @@
>
> #include <mach/mfp.h>
>
> -#include "nuc900-auido.h"
> +#include "nuc900-audio.h"
>
> static DEFINE_MUTEX(ac97_mutex);
> struct nuc900_audio *nuc900_ac97_data;
> diff --git a/sound/soc/nuc900/nuc900-auido.h b/sound/soc/nuc900/nuc900-audio.h
> similarity index 100%
> rename from sound/soc/nuc900/nuc900-auido.h
> rename to sound/soc/nuc900/nuc900-audio.h
I've just tried to build NUC900 as part of the ASoC multi-component work
and it looks like you didn't build this patch before sending it. The old
header name is still used in nuc900-audio.c and nuc900-pcm.c.
Can you send an incremental patch to fix this.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next parent reply other threads:[~2010-06-09 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C05F49A.8070309@gmail.com>
2010-06-09 13:33 ` Liam Girdwood [this message]
2010-06-09 13:47 ` [PATCH v2 4/4]AsoC/nuc900: fix a typo and rename the header file Wan ZongShun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276090429.3067.15.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=mcuos.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).