* [PATCH 1/6 v3] ASoC: fsi: modify format area definition on flags
@ 2010-07-13 9:13 Kuninori Morimoto
2010-07-13 10:50 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Kuninori Morimoto @ 2010-07-13 9:13 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux-ALSA
There is no necessity that each bit in this area has the meaning.
This patch modify it to sequence number
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v2 -> v3
o don't use << 0 shift
2/6 - 6/6 doesn't depend on 1/6 patch
include/sound/sh_fsi.h | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/sound/sh_fsi.h b/include/sound/sh_fsi.h
index c022736..3ecdb96 100644
--- a/include/sound/sh_fsi.h
+++ b/include/sound/sh_fsi.h
@@ -55,12 +55,12 @@
#define SH_FSI_GET_IFMT(x) ((x >> 8) & SH_FSI_FMT_MASK)
#define SH_FSI_GET_OFMT(x) ((x >> 0) & SH_FSI_FMT_MASK)
-#define SH_FSI_FMT_MONO (1 << 0)
-#define SH_FSI_FMT_MONO_DELAY (1 << 1)
-#define SH_FSI_FMT_PCM (1 << 2)
-#define SH_FSI_FMT_I2S (1 << 3)
-#define SH_FSI_FMT_TDM (1 << 4)
-#define SH_FSI_FMT_TDM_DELAY (1 << 5)
+#define SH_FSI_FMT_MONO 0
+#define SH_FSI_FMT_MONO_DELAY 1
+#define SH_FSI_FMT_PCM 2
+#define SH_FSI_FMT_I2S 3
+#define SH_FSI_FMT_TDM 4
+#define SH_FSI_FMT_TDM_DELAY 5
#define SH_FSI_IFMT_TDM_CH(x) \
(SH_FSI_IFMT(TDM) | SH_FSI_SET_CH_I(x))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6 v3] ASoC: fsi: modify format area definition on flags
2010-07-13 9:13 [PATCH 1/6 v3] ASoC: fsi: modify format area definition on flags Kuninori Morimoto
@ 2010-07-13 10:50 ` Liam Girdwood
2010-07-13 11:36 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2010-07-13 10:50 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linux-ALSA, Mark Brown
On Tue, 2010-07-13 at 18:13 +0900, Kuninori Morimoto wrote:
> There is no necessity that each bit in this area has the meaning.
> This patch modify it to sequence number
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v2 -> v3
>
> o don't use << 0 shift
>
> 2/6 - 6/6 doesn't depend on 1/6 patch
>
All
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6 v3] ASoC: fsi: modify format area definition on flags
2010-07-13 10:50 ` Liam Girdwood
@ 2010-07-13 11:36 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-07-13 11:36 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Linux-ALSA, Kuninori Morimoto
On Tue, Jul 13, 2010 at 11:50:38AM +0100, Liam Girdwood wrote:
> All
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-13 11:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-13 9:13 [PATCH 1/6 v3] ASoC: fsi: modify format area definition on flags Kuninori Morimoto
2010-07-13 10:50 ` Liam Girdwood
2010-07-13 11:36 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).