* [PATCH] wm8727: add a missing return in wm8727_platform_probe
@ 2010-07-14 10:57 Axel Lin
2010-07-14 14:59 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2010-07-14 10:57 UTC (permalink / raw)
To: linux-kernel
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Tejun Heo, Neil Jones, alsa-devel
otherwise the error path will always be executed.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/wm8727.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm8727.c b/sound/soc/codecs/wm8727.c
index 1072621..9d1df26 100644
--- a/sound/soc/codecs/wm8727.c
+++ b/sound/soc/codecs/wm8727.c
@@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev)
goto err_codec;
}
+ return 0;
+
err_codec:
snd_soc_unregister_codec(codec);
err:
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wm8727: add a missing return in wm8727_platform_probe
2010-07-14 10:57 [PATCH] wm8727: add a missing return in wm8727_platform_probe Axel Lin
@ 2010-07-14 14:59 ` Liam Girdwood
2010-07-14 19:26 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2010-07-14 14:59 UTC (permalink / raw)
To: Axel Lin
Cc: Neil Jones, alsa-devel, Takashi Iwai, Mark Brown, linux-kernel,
Tejun Heo
On Wed, 2010-07-14 at 18:57 +0800, Axel Lin wrote:
> otherwise the error path will always be executed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/wm8727.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8727.c b/sound/soc/codecs/wm8727.c
> index 1072621..9d1df26 100644
> --- a/sound/soc/codecs/wm8727.c
> +++ b/sound/soc/codecs/wm8727.c
> @@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev)
> goto err_codec;
> }
>
> + return 0;
> +
> err_codec:
> snd_soc_unregister_codec(codec);
> err:
Both
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wm8727: add a missing return in wm8727_platform_probe
2010-07-14 14:59 ` Liam Girdwood
@ 2010-07-14 19:26 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-07-14 19:26 UTC (permalink / raw)
To: Liam Girdwood
Cc: Neil Jones, alsa-devel, Takashi Iwai, linux-kernel, Tejun Heo,
Axel Lin
On Wed, Jul 14, 2010 at 03:59:57PM +0100, Liam Girdwood wrote:
> On Wed, 2010-07-14 at 18:57 +0800, Axel Lin wrote:
> > otherwise the error path will always be executed.
> Both
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
...and applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-14 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 10:57 [PATCH] wm8727: add a missing return in wm8727_platform_probe Axel Lin
2010-07-14 14:59 ` Liam Girdwood
2010-07-14 19:26 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).