HPI version 4.04.01

HPI version 4.04.01

[linux]

HPI stable driver 4.04.01 has just been released.
Only very minor patches since the last beta version.

Please also update alsa-firmware/asihpi with firmware from
http://audioscience.com/internet/download/drivers/released/v4/04/01/asihpi-firmware-40401.7z

[PATCH 7/9] HPI version 4.04.01

[linux]

From: Eliot Blennerhassett <eblennerhassett@audioscience.com>

Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
---
 pci/asihpi/hpi.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pci/asihpi/hpi.h b/pci/asihpi/hpi.h
index cee4df4..23399d0 100644
--- a/pci/asihpi/hpi.h
+++ b/pci/asihpi/hpi.h
@@ -50,8 +50,8 @@ i.e 3.05.02 is a development version
 #define HPI_VER_RELEASE(v) ((int)(v & 0xFF))
 
 /* Use single digits for versions less that 10 to avoid octal. */
-#define HPI_VER HPI_VERSION_CONSTRUCTOR(4L, 3, 36)
-#define HPI_VER_STRING "4.03.36"
+#define HPI_VER HPI_VERSION_CONSTRUCTOR(4L, 4, 1)
+#define HPI_VER_STRING "4.04.01"
 
 /* Library version as documented in hpi-api-versions.txt */
 #define HPI_LIB_VER  HPI_VERSION_CONSTRUCTOR(9, 0, 0)
-- 
1.7.0.4

[PATCH 8/9] Avoid using c99 uintX types.

[linux]

From: Eliot Blennerhassett <eblennerhassett@audioscience.com>

Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
---
 pci/asihpi/hpi_internal.h |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pci/asihpi/hpi_internal.h b/pci/asihpi/hpi_internal.h
index 7ae7a1d..16f502d 100644
--- a/pci/asihpi/hpi_internal.h
+++ b/pci/asihpi/hpi_internal.h
@@ -104,9 +104,9 @@ typedef void hpi_handler_func(struct hpi_message *, struct hpi_response *);
 #define STR_ROLE_FIELD_MAX 255U
 
 struct hpi_entity_str {
-	uint16_t size;
-	uint8_t type;
-	uint8_t role;
+	u16 size;
+	u8 type;
+	u8 role;
 };
 
 #if defined(_MSC_VER)
@@ -119,11 +119,11 @@ struct hpi_entity {
 #if ! defined(HPI_OS_DSP_C6000) || (defined(HPI_OS_DSP_C6000) && (__TI_COMPILER_VERSION__ > 6000008))
 	/* DSP C6000 compiler v6.0.8 and lower
 	   do not support  flexible array member */
-	uint8_t value[];
+	u8 value[];
 #else
 	/* NOTE! Using sizeof(struct hpi_entity) will give erroneous results */
 #define HPI_INTERNAL_WARN_ABOUT_ENTITY_VALUE
-	uint8_t value[1];
+	u8 value[1];
 #endif
 };
 
-- 
1.7.0.4

[PATCH 9/9] Avoid useless assignment of returned index values.

[linux]

From: Eliot Blennerhassett <eblennerhassett@audioscience.com>

Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
---
 pci/asihpi/hpifunc.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/pci/asihpi/hpifunc.c b/pci/asihpi/hpifunc.c
index 9c6958a..1e92eb6 100644
--- a/pci/asihpi/hpifunc.c
+++ b/pci/asihpi/hpifunc.c
@@ -2179,7 +2179,7 @@ u16 hpi_compander_get_attack_time_constant(const struct hpi_hsubsys
 	*ph_subsys, u32 h_control, unsigned int index, u32 *attack)
 {
 	return hpi_control_param_get(ph_subsys, h_control,
-		HPI_COMPANDER_ATTACK, 0, index, attack, &index);
+		HPI_COMPANDER_ATTACK, 0, index, attack, NULL);
 }
 
 u16 hpi_compander_set_decay_time_constant(const struct hpi_hsubsys *ph_subsys,
@@ -2193,7 +2193,7 @@ u16 hpi_compander_get_decay_time_constant(const struct hpi_hsubsys *ph_subsys,
 	u32 h_control, unsigned int index, u32 *decay)
 {
 	return hpi_control_param_get(ph_subsys, h_control,
-		HPI_COMPANDER_DECAY, 0, index, decay, &index);
+		HPI_COMPANDER_DECAY, 0, index, decay, NULL);
 
 }
 
@@ -2244,7 +2244,7 @@ u16 hpi_compander_get_ratio(const struct hpi_hsubsys *ph_subsys,
 	u32 h_control, u32 index, u32 *ratio100)
 {
 	return hpi_control_param_get(ph_subsys, h_control,
-		HPI_COMPANDER_RATIO, 0, index, ratio100, &index);
+		HPI_COMPANDER_RATIO, 0, index, ratio100, NULL);
 }
 
 u16 hpi_level_query_range(const struct hpi_hsubsys *ph_subsys, u32 h_control,
@@ -3258,8 +3258,7 @@ static inline size_t hpi_entity_item_count(struct hpi_entity *entity_ptr)
 static inline struct hpi_entity *hpi_entity_ptr_to_next(struct hpi_entity
 	*entity_ptr)
 {
-	return (void *)(((uint8_t *) entity_ptr) +
-		hpi_entity_size(entity_ptr));
+	return (void *)(((u8 *)entity_ptr) + hpi_entity_size(entity_ptr));
 }
 
 static inline u16 hpi_entity_check_type(const enum e_entity_type t)
-- 
1.7.0.4

Re: HPI version 4.04.01

[Takashi Iwai]

At Fri, 16 Jul 2010 17:50:58 +1200,
linux@audioscience.com wrote:
> 
> HPI stable driver 4.04.01 has just been released.
> Only very minor patches since the last beta version.

Eliot, I got only your posts from 7/9 to 9/9.
Where are the others?


thanks,

Takashi

Re: HPI version 4.04.01

[Eliot Blennerhassett]

On 16/07/10 18:34, Takashi Iwai wrote:
> At Fri, 16 Jul 2010 17:50:58 +1200,
> linux@audioscience.com wrote:
>>
>> HPI stable driver 4.04.01 has just been released.
>> Only very minor patches since the last beta version.
> 
> Eliot, I got only your posts from 7/9 to 9/9.
> Where are the others?

Oops, I didn't think about the sequence numbers. 1 to 6 are the ones I
sent a week or two ago.

There are only 3 patches in this set.

Can you apply as-is, or should I resend with amended subjects?

regards

-- 
Eliot Blennerhassett
AudioScience Inc.

Re: HPI version 4.04.01

[Takashi Iwai]

At Fri, 16 Jul 2010 20:57:51 +1200,
Eliot Blennerhassett wrote:
> 
> On 16/07/10 18:34, Takashi Iwai wrote:
> > At Fri, 16 Jul 2010 17:50:58 +1200,
> > linux@audioscience.com wrote:
> >>
> >> HPI stable driver 4.04.01 has just been released.
> >> Only very minor patches since the last beta version.
> > 
> > Eliot, I got only your posts from 7/9 to 9/9.
> > Where are the others?
> 
> Oops, I didn't think about the sequence numbers. 1 to 6 are the ones I
> sent a week or two ago.
> 
> There are only 3 patches in this set.
> 
> Can you apply as-is, or should I resend with amended subjects?

OK, I applied now three patches.


thanks,

Takashi