From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] asoc: davinci: let platform data define edma queue numbers
Date: Sat, 17 Jul 2010 18:28:53 +0100 [thread overview]
Message-ID: <1279387733.3070.0.camel@odin> (raw)
In-Reply-To: <1279196059-6031-1-git-send-email-nsekhar@ti.com>
On Thu, 2010-07-15 at 17:44 +0530, Sekhar Nori wrote:
> Currently the EDMA queue to be used by for servicing ASP through
> internal RAM is fixed to EDMAQ_0 and that to service internal RAM
> from external RAM is fixed to EDMAQ_1.
>
> This may not be the desirable configuration on all platforms. For
> example, on DM365, queue 0 has large fifo size and is more suitable
> for video transfers. Having audio and video transfers on the same
> queue may lead to starvation on audio side.
>
> platform data as defined currently passes a queue number to the driver
> but that remains unused inside the driver.
>
> Fix this by defining one queue each for ASP and RAM transfers in the
> platform data and using it inside the driver.
>
> Since EDMAQ_0 maps to 0, thats the queue that will be used if
> the asp queue number is not initialized. None of the platforms
> currently utilize ping-pong transfers through internal RAM so that
> functionality remains unchanged too.
>
> This patch has been tested on DM644x and OMAP-L138 EVMs.
>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-07-17 17:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 12:14 [PATCH] asoc: davinci: let platform data define edma queue numbers Sekhar Nori
2010-07-17 17:28 ` Liam Girdwood [this message]
2010-07-17 18:50 ` Mark Brown
[not found] ` <20100717185018.GC27456-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2010-07-19 7:05 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279387733.3070.0.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox