public inbox for alsa-devel@alsa-project.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Timur Tabi <timur@freescale.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: asoc multi-component: CPU DAI name is wrong
Date: Fri, 23 Jul 2010 19:16:23 +0100	[thread overview]
Message-ID: <1279908983.3076.8.camel@odin> (raw)
In-Reply-To: <4C48BEBA.8080207@freescale.com>

On Thu, 2010-07-22 at 16:57 -0500, Timur Tabi wrote:
> Liam,
> 
> I have this in my machine driver:
> 
> machine_data->dai[0].cpu_dai_name = strrchr(np->full_name, '/') + 1;
> printk(KERN_INFO "%s:%u cpu_dai_name=%s\n", __func__, __LINE__,
> machine_data->dai[0].cpu_dai_name);
> ...
> platform_set_drvdata(sound_device, &machine_data->card);
> ret = platform_device_add(sound_device);
> 
> which displays this message:
> 
> mpc8610_hpcd_probe:316 cpu_dai_name=ssi@16000
> 
> So my machine driver says the CPU DAI name is "ssi@16000", and my CPU driver
> does the same thing.  However, I put some printks in soc_bind_dai_link, and
> this is what I see:
> 
> soc_bind_dai_link:1136 cpu_dai->name=e0016000.ssi
> dai_link->cpu_dai_name=ssi@16000
> soc_bind_dai_link:1136 cpu_dai->name=cs4270-hifi
> dai_link->cpu_dai_name=ssi@16000
> soc_bind_dai_link:1159 codec->name=0-004f
> dai_link->codec_name=cs4270-codec.0-004f
> soc_bind_dai_link:1193 platform->name=e0021180.dma-channel
> dai_link->platform_name=/soc@e0000000/dma@21300/dma-channel@0
> soc_bind_dai_link:1193 platform->name=e0021100.dma-channel
> dai_link->platform_name=/soc@e0000000/dma@21300/dma-channel@0
> soc_bind_dai_link:1136 cpu_dai->name=e0016000.ssi
> dai_link->cpu_dai_name=ssi@16000
> soc_bind_dai_link:1136 cpu_dai->name=cs4270-hifi
> dai_link->cpu_dai_name=ssi@16000
> soc_bind_dai_link:1159 codec->name=0-004f
> dai_link->codec_name=cs4270-codec.0-004f
> soc_bind_dai_link:1193 platform->name=e0021180.dma-channel
> dai_link->platform_name=/soc@e0000000/dma@21300/dma-channel@1
> soc_bind_dai_link:1193 platform->name=e0021100.dma-channel
> dai_link->platform_name=/soc@e0000000/dma@21300/dma-channel@1
> 
> Where in the world is "e0016000.ssi" coming from?  Why is ASoC ignoring my
> .cpu_dai_name value?
> 

My mistake, I'd missed something in the forward port. I've fixed the DAI
naming problem and you should see your DAI use the correct name.

Give kernel.org about 30 mins to sync before pulling.

Thanks

Liam  
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-07-23 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 21:57 asoc multi-component: CPU DAI name is wrong Timur Tabi
2010-07-23 18:16 ` Liam Girdwood [this message]
2010-07-23 18:56   ` Timur Tabi
2010-07-24  9:42     ` Liam Girdwood
2010-07-26 18:57       ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279908983.3076.8.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox