From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kulikov Vasiliy Subject: [PATCH 06/10] ALSA: msnd: check request_region() return value Date: Wed, 28 Jul 2010 20:40:21 +0400 Message-ID: <1280335221-23345-1-git-send-email-segooon@gmail.com> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: kernel-janitors@vger.kernel.org Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org request_region() may fail, if so return -ENOMEM. Signed-off-by: Kulikov Vasiliy --- sound/isa/msnd/msnd_pinnacle.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/sound/isa/msnd/msnd_pinnacle.c b/sound/isa/msnd/msnd_pinnacle.c index 60b6abd..ed42f8e 100644 --- a/sound/isa/msnd/msnd_pinnacle.c +++ b/sound/isa/msnd/msnd_pinnacle.c @@ -549,7 +549,10 @@ static int __devinit snd_msnd_attach(struct snd_card *card) printk(KERN_ERR LOGNAME ": Couldn't grab IRQ %d\n", chip->irq); return err; } - request_region(chip->io, DSP_NUMIO, card->shortname); + if (request_region(chip->io, DSP_NUMIO, card->shortname) == NULL) { + free_irq(chip->irq, chip); + return -ENOMEM; + } if (!request_mem_region(chip->base, BUFFSIZE, card->shortname)) { printk(KERN_ERR LOGNAME -- 1.7.0.4