From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Support non-crystal master clocks for WM8731
Date: Wed, 18 Aug 2010 16:22:49 +0100 [thread overview]
Message-ID: <1282144969.3117.603.camel@odin> (raw)
In-Reply-To: <1282144793-32137-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Wed, 2010-08-18 at 16:19 +0100, Mark Brown wrote:
> Instead of unconditionally enabling the crystal oscillator on the WM8731
> only enable it when explicitly selected via set_sysclk(), allowing machine
> drivers to specify that they drive a clock into MCLK alone. This avoids
> any conflicts between the oscillator and the external MCLK source and saves
> power for systems which do not need the oscillator.
>
> This should also deliver a small power saving on systems using the crystal
> since the oscillator will only be enabled when the ADC or DAC is active.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-08-18 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 15:19 [PATCH] ASoC: Support non-crystal master clocks for WM8731 Mark Brown
2010-08-18 15:22 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282144969.3117.603.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).