alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Nikula <jhnikula@gmail.com>
To: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: [PATCH 0/4] ASoC: tlv320aic3x: Output stage cleanup
Date: Fri, 27 Aug 2010 16:56:46 +0300	[thread overview]
Message-ID: <1282917410-12000-1-git-send-email-jhnikula@gmail.com> (raw)

Hi

I have had always difficulties to remember which aic3x mixer control controls
what route but haven't bothered to look any deeper until very recently
after wondering why the swapped routes aren't working. It turned out that
there were two reasons:

1. Output mixers were misdefined to mix output pins to internal signals
   where DAPM logic and hw as well does opposite
2. Swapped routes are not working due this misdefinition

Then there wasn't uniform way to represent and name volume controls for those
output mixer stages.

This patchset does first some minor cleanups, then fixes the mixer stage
also adding a few missing routes and then puts hopefully some logic to
output controls.

Unfortunately this means control name changes but hopefully driver is now more
understandable and complete.


-- 
Jarkko

             reply	other threads:[~2010-08-27 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 13:56 Jarkko Nikula [this message]
2010-08-27 13:56 ` [PATCH 1/4] ASoC: tlv320aic3x: Fix remaining output pin switch names Jarkko Nikula
2010-08-27 14:17   ` Mark Brown
2010-08-28  9:58     ` Liam Girdwood
2010-08-27 13:56 ` [PATCH 2/4] ASoC: tlv320aic3x: Sort output pin control registers in header file Jarkko Nikula
2010-08-27 14:18   ` Mark Brown
2010-08-27 13:56 ` [PATCH 3/4] ASoC: tlv320aic3x: Reimplement output mixers Jarkko Nikula
2010-08-27 14:21   ` Mark Brown
2010-08-27 13:56 ` [PATCH 4/4] ASoC: tlv320aic3x: Sanitize output controls Jarkko Nikula
2010-08-27 14:24   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282917410-12000-1-git-send-email-jhnikula@gmail.com \
    --to=jhnikula@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).