* [PATCH] sound: oss: fix uninitialized spinlock
@ 2010-08-28 4:25 Akinobu Mita
2010-08-28 10:02 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2010-08-28 4:25 UTC (permalink / raw)
To: alsa-devel; +Cc: Takashi Iwai, Akinobu Mita
The spinlock lock in sound_timer.c is used without initialization.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>
---
sound/oss/sound_timer.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/oss/sound_timer.c b/sound/oss/sound_timer.c
index f0f0c19..48cda6c 100644
--- a/sound/oss/sound_timer.c
+++ b/sound/oss/sound_timer.c
@@ -26,7 +26,7 @@ static unsigned long prev_event_time;
static volatile unsigned long usecs_per_tmr; /* Length of the current interval */
static struct sound_lowlev_timer *tmr;
-static spinlock_t lock;
+static DEFINE_SPINLOCK(lock);
static unsigned long tmr2ticks(int tmr_value)
{
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sound: oss: fix uninitialized spinlock
2010-08-28 4:25 [PATCH] sound: oss: fix uninitialized spinlock Akinobu Mita
@ 2010-08-28 10:02 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2010-08-28 10:02 UTC (permalink / raw)
To: Akinobu Mita; +Cc: alsa-devel
At Sat, 28 Aug 2010 13:25:33 +0900,
Akinobu Mita wrote:
>
> The spinlock lock in sound_timer.c is used without initialization.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
Applied now. Thanks.
Takashi
> ---
> sound/oss/sound_timer.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/oss/sound_timer.c b/sound/oss/sound_timer.c
> index f0f0c19..48cda6c 100644
> --- a/sound/oss/sound_timer.c
> +++ b/sound/oss/sound_timer.c
> @@ -26,7 +26,7 @@ static unsigned long prev_event_time;
> static volatile unsigned long usecs_per_tmr; /* Length of the current interval */
>
> static struct sound_lowlev_timer *tmr;
> -static spinlock_t lock;
> +static DEFINE_SPINLOCK(lock);
>
> static unsigned long tmr2ticks(int tmr_value)
> {
> --
> 1.6.0.6
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-28 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-28 4:25 [PATCH] sound: oss: fix uninitialized spinlock Akinobu Mita
2010-08-28 10:02 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).