* [PATCH] ASoC: Swap bias level enumeration
@ 2010-08-31 11:52 Jarkko Nikula
2010-08-31 12:03 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Nikula @ 2010-08-31 11:52 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Liam Girdwood
Swapping the bias level enumeration is only meant to help debugging. It is
easier if number 0 means bias off and bigger number means bigger bias level.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
include/sound/soc.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index d31e8b7..493b3a4 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -214,10 +214,10 @@
* @OFF: Power Off. No restrictions on transition times.
*/
enum snd_soc_bias_level {
- SND_SOC_BIAS_ON,
- SND_SOC_BIAS_PREPARE,
- SND_SOC_BIAS_STANDBY,
SND_SOC_BIAS_OFF,
+ SND_SOC_BIAS_STANDBY,
+ SND_SOC_BIAS_PREPARE,
+ SND_SOC_BIAS_ON,
};
struct snd_jack;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: Swap bias level enumeration
2010-08-31 11:52 [PATCH] ASoC: Swap bias level enumeration Jarkko Nikula
@ 2010-08-31 12:03 ` Liam Girdwood
2010-08-31 12:06 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2010-08-31 12:03 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: alsa-devel, Mark Brown
On Tue, 2010-08-31 at 14:52 +0300, Jarkko Nikula wrote:
> Swapping the bias level enumeration is only meant to help debugging. It is
> easier if number 0 means bias off and bigger number means bigger bias level.
>
Good point.
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Swap bias level enumeration
2010-08-31 12:03 ` Liam Girdwood
@ 2010-08-31 12:06 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-08-31 12:06 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel
On Tue, Aug 31, 2010 at 01:03:44PM +0100, Liam Girdwood wrote:
> On Tue, 2010-08-31 at 14:52 +0300, Jarkko Nikula wrote:
> > Swapping the bias level enumeration is only meant to help debugging. It is
> > easier if number 0 means bias off and bigger number means bigger bias level.
> Good point.
Personally I always display as plain text which is even more legible :)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-31 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-31 11:52 [PATCH] ASoC: Swap bias level enumeration Jarkko Nikula
2010-08-31 12:03 ` Liam Girdwood
2010-08-31 12:06 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).