From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Jiri Slaby <jslaby@suse.cz>
Cc: alsa-devel@alsa-project.org,
Liam Girdwood <lg@opensource.wolfsonmicro.com>,
jirislaby@gmail.com, tiwai@suse.de,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@suse.cz>
Subject: Re: [PATCH 1/1] SOUND: wm8753, remove dead code
Date: Mon, 06 Sep 2010 11:32:30 +0100 [thread overview]
Message-ID: <1283769150.3078.15.camel@odin> (raw)
In-Reply-To: <1283605929-15961-1-git-send-email-jslaby@suse.cz>
On Sat, 2010-09-04 at 15:12 +0200, Jiri Slaby wrote:
> There is adangling code in wm8753_probe which is never executed.
> Remove it.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Liam Girdwood <lg@opensource.wolfsonmicro.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@suse.cz>
> ---
> sound/soc/codecs/wm8753.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
> index 4844232..4a945d3 100644
> --- a/sound/soc/codecs/wm8753.c
> +++ b/sound/soc/codecs/wm8753.c
> @@ -1600,9 +1600,6 @@ static int wm8753_probe(struct snd_soc_codec *codec)
> wm8753_add_widgets(codec);
>
> return 0;
> -
> - run_delayed_work(&codec->delayed_work);
> - return ret;
> }
>
> /* power down chip */
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-09-06 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 13:12 [PATCH 1/1] SOUND: wm8753, remove dead code Jiri Slaby
2010-09-06 10:32 ` Liam Girdwood [this message]
2010-09-06 10:44 ` Mark Brown
2010-09-07 4:12 ` s3c6410/s3c64xx support in ALSA Reddy, MR Swami
2010-09-08 8:45 ` Seungwhan Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283769150.3078.15.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=lg@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).