From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig Date: Fri, 10 Sep 2010 12:20:04 +0100 Message-ID: <1284117604.3088.229.camel@odin> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f179.google.com (mail-wy0-f179.google.com [74.125.82.179]) by alsa0.perex.cz (Postfix) with ESMTP id D5F8B103982 for ; Fri, 10 Sep 2010 13:20:07 +0200 (CEST) Received: by wyb32 with SMTP id 32so2576902wyb.38 for ; Fri, 10 Sep 2010 04:20:07 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Kuninori Morimoto Cc: Linux-ALSA , Mark Brown , Guennadi List-Id: alsa-devel@alsa-project.org On Fri, 2010-09-10 at 10:34 +0900, Kuninori Morimoto wrote: > Current SND_FSI_xxx menu attributes were bool, > but it should be tristate. > This patch solve below report from Guennadi > > "bool" means, if someone is linking the whole ASoC into the kernel, they > will not be able to build this as a module. Not a big deal, but you're > stealing some freedom from the user. > > Reported-by: Guennadi Liakhovetski > Signed-off-by: Kuninori Morimoto Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk