From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Report error code when failing to add controls
Date: Tue, 21 Sep 2010 14:06:43 +0100 [thread overview]
Message-ID: <1285074403.3089.41.camel@odin> (raw)
In-Reply-To: <1285006551-24084-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Mon, 2010-09-20 at 19:15 +0100, Mark Brown wrote:
> Helps with diagnostics.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 8d8c5cd..7c64e03 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1983,8 +1983,8 @@ int snd_soc_add_controls(struct snd_soc_codec *codec,
> const struct snd_kcontrol_new *control = &controls[i];
> err = snd_ctl_add(card, snd_soc_cnew(control, codec, NULL));
> if (err < 0) {
> - dev_err(codec->dev, "%s: Failed to add %s\n",
> - codec->name, control->name);
> + dev_err(codec->dev, "%s: Failed to add %s: %d\n",
> + codec->name, control->name, err);
> return err;
> }
> }
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-09-21 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 18:15 [PATCH] ASoC: Report error code when failing to add controls Mark Brown
2010-09-21 13:06 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285074403.3089.41.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox