* [PATCH] ASoC: Report error code when failing to add controls
@ 2010-09-20 18:15 Mark Brown
2010-09-21 13:06 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2010-09-20 18:15 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, Mark Brown
Helps with diagnostics.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/soc-core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 8d8c5cd..7c64e03 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1983,8 +1983,8 @@ int snd_soc_add_controls(struct snd_soc_codec *codec,
const struct snd_kcontrol_new *control = &controls[i];
err = snd_ctl_add(card, snd_soc_cnew(control, codec, NULL));
if (err < 0) {
- dev_err(codec->dev, "%s: Failed to add %s\n",
- codec->name, control->name);
+ dev_err(codec->dev, "%s: Failed to add %s: %d\n",
+ codec->name, control->name, err);
return err;
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Report error code when failing to add controls
2010-09-20 18:15 [PATCH] ASoC: Report error code when failing to add controls Mark Brown
@ 2010-09-21 13:06 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2010-09-21 13:06 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel
On Mon, 2010-09-20 at 19:15 +0100, Mark Brown wrote:
> Helps with diagnostics.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-core.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 8d8c5cd..7c64e03 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1983,8 +1983,8 @@ int snd_soc_add_controls(struct snd_soc_codec *codec,
> const struct snd_kcontrol_new *control = &controls[i];
> err = snd_ctl_add(card, snd_soc_cnew(control, codec, NULL));
> if (err < 0) {
> - dev_err(codec->dev, "%s: Failed to add %s\n",
> - codec->name, control->name);
> + dev_err(codec->dev, "%s: Failed to add %s: %d\n",
> + codec->name, control->name, err);
> return err;
> }
> }
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-21 13:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-20 18:15 [PATCH] ASoC: Report error code when failing to add controls Mark Brown
2010-09-21 13:06 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).