From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Report error codes for card DAI instantiation failures
Date: Wed, 22 Sep 2010 09:54:49 +0100 [thread overview]
Message-ID: <1285145689.3107.6.camel@odin> (raw)
In-Reply-To: <1285086241-26354-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Tue, 2010-09-21 at 17:24 +0100, Mark Brown wrote:
> Also clean up the error print a bit.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 7c64e03..5c58651 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1568,7 +1568,8 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card)
> for (i = 0; i < card->num_links; i++) {
> ret = soc_probe_dai_link(card, i);
> if (ret < 0) {
> - printk(KERN_ERR "asoc: failed to instanciate card %s\n", card->name);
> + pr_err("asoc: failed to instantiate card %s: %d\n",
> + card->name, ret);
> goto probe_dai_err;
> }
> }
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-09-22 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 16:24 [PATCH] ASoC: Report error codes for card DAI instantiation failures Mark Brown
2010-09-22 8:54 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285145689.3107.6.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox