* [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration
@ 2010-09-30 21:26 Mark Brown
2010-09-30 21:50 ` Liam Girdwood
2010-10-02 11:03 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2010-09-30 21:26 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
The restrictions on configuring BCLK are overly cautious, other constraints
in the system should ensure that reconfiguration is not possible when the
device is sufficiently active to be unable to support reclocking.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8962.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
index be34146..38cbf85 100644
--- a/sound/soc/codecs/wm8962.c
+++ b/sound/soc/codecs/wm8962.c
@@ -911,12 +911,6 @@ static void wm8962_configure_bclk(struct snd_soc_codec *codec)
int clocking2 = 0;
int aif2 = 0;
- /* If the CODEC is powered on we can configure BCLK */
- if (codec->bias_level != SND_SOC_BIAS_OFF) {
- dev_dbg(codec->dev, "Bias is off, can't configure BCLK\n");
- return;
- }
-
if (!wm8962->bclk) {
dev_dbg(codec->dev, "No BCLK rate configured\n");
return;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration
2010-09-30 21:26 [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration Mark Brown
@ 2010-09-30 21:50 ` Liam Girdwood
2010-10-02 11:03 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-09-30 21:50 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On Thu, 2010-09-30 at 14:26 -0700, Mark Brown wrote:
> The restrictions on configuring BCLK are overly cautious, other constraints
> in the system should ensure that reconfiguration is not possible when the
> device is sufficiently active to be unable to support reclocking.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8962.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
> index be34146..38cbf85 100644
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -911,12 +911,6 @@ static void wm8962_configure_bclk(struct snd_soc_codec *codec)
> int clocking2 = 0;
> int aif2 = 0;
>
> - /* If the CODEC is powered on we can configure BCLK */
> - if (codec->bias_level != SND_SOC_BIAS_OFF) {
> - dev_dbg(codec->dev, "Bias is off, can't configure BCLK\n");
> - return;
> - }
> -
> if (!wm8962->bclk) {
> dev_dbg(codec->dev, "No BCLK rate configured\n");
> return;
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration
2010-09-30 21:26 [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration Mark Brown
2010-09-30 21:50 ` Liam Girdwood
@ 2010-10-02 11:03 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-10-02 11:03 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On Thu, 2010-09-30 at 14:26 -0700, Mark Brown wrote:
> The restrictions on configuring BCLK are overly cautious, other constraints
> in the system should ensure that reconfiguration is not possible when the
> device is sufficiently active to be unable to support reclocking.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-02 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-30 21:26 [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration Mark Brown
2010-09-30 21:50 ` Liam Girdwood
2010-10-02 11:03 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).