From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration
Date: Thu, 30 Sep 2010 22:50:59 +0100 [thread overview]
Message-ID: <1285883459.3101.130.camel@odin> (raw)
In-Reply-To: <1285882000-17669-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Thu, 2010-09-30 at 14:26 -0700, Mark Brown wrote:
> The restrictions on configuring BCLK are overly cautious, other constraints
> in the system should ensure that reconfiguration is not possible when the
> device is sufficiently active to be unable to support reclocking.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8962.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
> index be34146..38cbf85 100644
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -911,12 +911,6 @@ static void wm8962_configure_bclk(struct snd_soc_codec *codec)
> int clocking2 = 0;
> int aif2 = 0;
>
> - /* If the CODEC is powered on we can configure BCLK */
> - if (codec->bias_level != SND_SOC_BIAS_OFF) {
> - dev_dbg(codec->dev, "Bias is off, can't configure BCLK\n");
> - return;
> - }
> -
> if (!wm8962->bclk) {
> dev_dbg(codec->dev, "No BCLK rate configured\n");
> return;
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-09-30 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 21:26 [PATCH] ASoC: Relax restrictions on WM8962 BCLK configuration Mark Brown
2010-09-30 21:50 ` Liam Girdwood [this message]
2010-10-02 11:03 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285883459.3101.130.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).