Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@suse.cz>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsaucm: Report failure to set a device due to missing verb setup
Date: Sun, 10 Oct 2010 11:45:54 +0100	[thread overview]
Message-ID: <1286707554.3429.19.camel@odin> (raw)
In-Reply-To: <1286572314-8035-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Fri, 2010-10-08 at 14:11 -0700, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  alsaucm/usecase.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/alsaucm/usecase.c b/alsaucm/usecase.c
> index 2db26f1..d1420c0 100644
> --- a/alsaucm/usecase.c
> +++ b/alsaucm/usecase.c
> @@ -94,8 +94,10 @@ static int list_verb_device_status(snd_use_case_mgr_t *uc_mgr)
>  	int i, enabled, num;
>  
>  	verb = snd_use_case_get_verb(uc_mgr);
> -	if (verb == NULL)
> +	if (verb == NULL) {
> +		printf(" no verb currently enabled.\n");
>  		return -ENODEV;
> +	}
>  
>  	num = snd_use_case_get_device_list(uc_mgr, verb, &device_list);
>  	if (num <= 0) {

Both Applied.

Jaroslav, are you going to apply these to your ucm branch ?

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

      reply	other threads:[~2010-10-10 10:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 21:11 [PATCH] alsaucm: Report failure to set a device due to missing verb setup Mark Brown
2010-10-10 10:45 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286707554.3429.19.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox