From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 4/5] ASoC: fsi: Add fsi_is_play function
Date: Tue, 12 Oct 2010 10:16:19 +0100 [thread overview]
Message-ID: <1286874979.3267.5.camel@odin> (raw)
In-Reply-To: <w3ppqvgrv56.wl%kuninori.morimoto.gx@renesas.com>
On Tue, 2010-10-12 at 11:40 +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/sh/fsi.c | 13 +++++++++----
> 1 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
> index 2b3a50d..09a2df2 100644
> --- a/sound/soc/sh/fsi.c
> +++ b/sound/soc/sh/fsi.c
> @@ -295,6 +295,11 @@ static u32 fsi_get_info_flags(struct fsi_priv *fsi)
> master->info->portb_flags;
> }
>
> +static int fsi_is_play(struct snd_pcm_substream *substream)
> +{
> + return substream->stream == SNDRV_PCM_STREAM_PLAYBACK;
> +}
> +
It may be better to make this inline since it's very small.
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-10-12 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 2:38 [PATCH 0/5] ASoC: fsi: clean up patches Kuninori Morimoto
2010-10-12 2:39 ` [PATCH 1/5] ASoC: fsi: Add fsi_get_frame_width function Kuninori Morimoto, Kuninori Morimoto
2010-10-12 2:39 ` [PATCH 2/5] ASoC: fsi: remove un-necessary variable from fsi_dai_startup Kuninori Morimoto, Kuninori Morimoto
2010-10-12 2:40 ` [PATCH 3/5] ASoC: fsi: avoid un-necessary status read Kuninori Morimoto, Kuninori Morimoto
2010-10-12 2:40 ` [PATCH 4/5] ASoC: fsi: Add fsi_is_play function Kuninori Morimoto, Kuninori Morimoto
2010-10-12 9:16 ` Liam Girdwood [this message]
2010-10-12 9:30 ` [PATCH 4/5 v2] ASoC: " Kuninori Morimoto
2010-10-12 2:40 ` [PATCH 5/5] ASoC: fsi: Add new macro and shift for PortA/B In/Out Kuninori Morimoto, Kuninori Morimoto
2010-10-12 9:16 ` [PATCH 0/5] ASoC: fsi: clean up patches Liam Girdwood
2010-10-12 10:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286874979.3267.5.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox