From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] ASoC: fsi: simultaneous playback/recorde support
Date: Tue, 12 Oct 2010 10:41:07 +0100 [thread overview]
Message-ID: <1286876467.3267.30.camel@odin> (raw)
In-Reply-To: <w3pocazrc1b.wl%kuninori.morimoto.gx@renesas.com>
On Tue, 2010-10-12 at 18:33 +0900, Kuninori Morimoto wrote:
> Dear Liam
>
> Thank you for your checking patch
>
> > > +/* is */
> > > +#define IS_PLAY 1
> > > +#define IS_CAPTURE 0
> >
> > Please use SNDRV_PCM_STREAM_PLAYBACK and SNDRV_PCM_STREAM_CAPTURE here.
>
> understand but ...
> I think
> SNDRV_PCM_STREAM_PLAYBACK = 0
> SNDRV_PCM_STREAM_CAPTURE = 1
>
> But in fsi driver, IS_PLAY needs 1, IS_CAPTURE needs 0 for now.
> should I modify all of these ?
Yes, we need to keep consistency with ALSA.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-10-12 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 4:38 [PATCH 0/2] ASoC: simultaneous playback/recorde support for SH board Kuninori Morimoto
2010-10-12 4:39 ` [PATCH 1/2] ASoC: fsi: simultaneous playback/recorde support Kuninori Morimoto, Kuninori Morimoto
2010-10-12 9:19 ` Liam Girdwood
2010-10-12 9:33 ` Kuninori Morimoto
2010-10-12 9:41 ` Liam Girdwood [this message]
2010-10-12 10:19 ` [PATCH 1/2 v2] " Kuninori Morimoto
2010-10-15 10:06 ` Mark Brown
2010-10-12 4:39 ` [PATCH 2/2] ASoC: ak4642: " Kuninori Morimoto, Kuninori Morimoto
2010-10-12 9:38 ` Liam Girdwood
2010-10-12 10:00 ` Mark Brown
2010-10-12 10:22 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286876467.3267.30.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).