From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Add WM8962 microphone bias control
Date: Wed, 13 Oct 2010 10:30:04 +0100 [thread overview]
Message-ID: <1286962204.3282.26.camel@odin> (raw)
In-Reply-To: <1286908637-10424-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Tue, 2010-10-12 at 19:37 +0100, Mark Brown wrote:
> We unconditionally require SYSCLK since while only microphone detection
> specifically requires SYSCLK any actual use case would enable it via
> some other means but microphone detection may have nothing active other
> than the bias itself.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8962.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
> index e5009d0..894d0cd 100644
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -2566,6 +2566,8 @@ static const struct snd_soc_dapm_route wm8962_intercon[] = {
> { "MIXINR", "IN3R Switch", "IN3R" },
> { "MIXINR", "PGA Switch", "INPGAR" },
>
> + { "MICBIAS", NULL, "SYSCLK" },
> +
> { "ADCL", NULL, "SYSCLK" },
> { "ADCL", NULL, "TOCLK" },
> { "ADCL", NULL, "MIXINL" },
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-10-13 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 18:37 [PATCH] ASoC: Add WM8962 microphone bias control Mark Brown
2010-10-13 9:30 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286962204.3282.26.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).