alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740
@ 2010-10-29 13:47 Jarkko Nikula
  2010-10-29 13:47 ` [PATCH 2/2] ASoC: Include cx20442 to SND_SOC_ALL_CODECS Jarkko Nikula
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jarkko Nikula @ 2010-10-29 13:47 UTC (permalink / raw)
  To: alsa-devel; +Cc: Mark Brown, Liam Girdwood

Include alc5623.c and jz4740.c to SND_SOC_ALL_CODECS when their other
dependencies are met.

Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
 sound/soc/codecs/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 658cbe0..86d24d4 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -22,12 +22,12 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_AK4535 if I2C
 	select SND_SOC_AK4642 if I2C
 	select SND_SOC_AK4671 if I2C
-	select SND_SOC_ALC562 if I2C
+	select SND_SOC_ALC5623 if I2C
 	select SND_SOC_CQ0093VC if MFD_DAVINCI_VOICECODEC
 	select SND_SOC_CS42L51 if I2C
 	select SND_SOC_CS4270 if I2C
 	select SND_SOC_DA7210 if I2C
-	select SND_SOC_JZ4740 if SOC_JZ4740
+	select SND_SOC_JZ4740_CODEC if SOC_JZ4740
 	select SND_SOC_MAX98088 if I2C
 	select SND_SOC_MAX9877 if I2C
 	select SND_SOC_PCM3008
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ASoC: Include cx20442 to SND_SOC_ALL_CODECS
  2010-10-29 13:47 [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740 Jarkko Nikula
@ 2010-10-29 13:47 ` Jarkko Nikula
  2010-10-30 16:31 ` [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740 Liam Girdwood
  2010-11-01 13:22 ` Mark Brown
  2 siblings, 0 replies; 6+ messages in thread
From: Jarkko Nikula @ 2010-10-29 13:47 UTC (permalink / raw)
  To: alsa-devel; +Cc: Mark Brown, Liam Girdwood

Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
 sound/soc/codecs/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 86d24d4..e61fbab 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -26,6 +26,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_CQ0093VC if MFD_DAVINCI_VOICECODEC
 	select SND_SOC_CS42L51 if I2C
 	select SND_SOC_CS4270 if I2C
+	select SND_SOC_CX20442
 	select SND_SOC_DA7210 if I2C
 	select SND_SOC_JZ4740_CODEC if SOC_JZ4740
 	select SND_SOC_MAX98088 if I2C
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740
  2010-10-29 13:47 [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740 Jarkko Nikula
  2010-10-29 13:47 ` [PATCH 2/2] ASoC: Include cx20442 to SND_SOC_ALL_CODECS Jarkko Nikula
@ 2010-10-30 16:31 ` Liam Girdwood
  2010-11-01 13:22 ` Mark Brown
  2 siblings, 0 replies; 6+ messages in thread
From: Liam Girdwood @ 2010-10-30 16:31 UTC (permalink / raw)
  To: Jarkko Nikula; +Cc: alsa-devel, Mark Brown

On Fri, 2010-10-29 at 16:47 +0300, Jarkko Nikula wrote:
> Include alc5623.c and jz4740.c to SND_SOC_ALL_CODECS when their other
> dependencies are met.
> 
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> ---

Both

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740
  2010-10-29 13:47 [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740 Jarkko Nikula
  2010-10-29 13:47 ` [PATCH 2/2] ASoC: Include cx20442 to SND_SOC_ALL_CODECS Jarkko Nikula
  2010-10-30 16:31 ` [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740 Liam Girdwood
@ 2010-11-01 13:22 ` Mark Brown
  2010-11-01 13:31   ` Jarkko Nikula
  2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2010-11-01 13:22 UTC (permalink / raw)
  To: Jarkko Nikula; +Cc: alsa-devel, Liam Girdwood

On Fri, Oct 29, 2010 at 04:47:44PM +0300, Jarkko Nikula wrote:

>  	select SND_SOC_AK4671 if I2C
> -	select SND_SOC_ALC562 if I2C
> +	select SND_SOC_ALC5623 if I2C

This patch doesn't apply as-is since this CODEC isn't in mainline.  I've
dropped it from the patch and applied together with the second patch.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740
  2010-11-01 13:22 ` Mark Brown
@ 2010-11-01 13:31   ` Jarkko Nikula
  2010-11-01 13:46     ` Mark Brown
  0 siblings, 1 reply; 6+ messages in thread
From: Jarkko Nikula @ 2010-11-01 13:31 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, Liam Girdwood

On Mon, 1 Nov 2010 09:22:56 -0400
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> On Fri, Oct 29, 2010 at 04:47:44PM +0300, Jarkko Nikula wrote:
> 
> >  	select SND_SOC_AK4671 if I2C
> > -	select SND_SOC_ALC562 if I2C
> > +	select SND_SOC_ALC5623 if I2C
> 
> This patch doesn't apply as-is since this CODEC isn't in mainline.  I've
> dropped it from the patch and applied together with the second patch.

Ah, I forgot to point these were for 2.6.38 and thus alc5623 were
here. I thought SND_SOC_ALL_CODECS is useful only to ASoC developers
and didn't consider .37 at all :-)


-- 
Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740
  2010-11-01 13:31   ` Jarkko Nikula
@ 2010-11-01 13:46     ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2010-11-01 13:46 UTC (permalink / raw)
  To: Jarkko Nikula; +Cc: alsa-devel, Liam Girdwood

On Mon, Nov 01, 2010 at 03:31:12PM +0200, Jarkko Nikula wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> > This patch doesn't apply as-is since this CODEC isn't in mainline.  I've
> > dropped it from the patch and applied together with the second patch.

> Ah, I forgot to point these were for 2.6.38 and thus alc5623 were
> here. I thought SND_SOC_ALL_CODECS is useful only to ASoC developers
> and didn't consider .37 at all :-)

Ah, please resubmit the separate patch fo 2.6.38.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-11-01 13:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-29 13:47 [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740 Jarkko Nikula
2010-10-29 13:47 ` [PATCH 2/2] ASoC: Include cx20442 to SND_SOC_ALL_CODECS Jarkko Nikula
2010-10-30 16:31 ` [PATCH 1/2] ASoC: Fix SND_SOC_ALL_CODECS typos for alc5623 and jz4740 Liam Girdwood
2010-11-01 13:22 ` Mark Brown
2010-11-01 13:31   ` Jarkko Nikula
2010-11-01 13:46     ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).