* [PATCH] ASoC: WM8776: Removed unneeded struct member
@ 2010-11-05 10:36 Dimitris Papastamos
2010-11-06 11:01 ` Liam Girdwood
2010-11-06 15:12 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dimitris Papastamos @ 2010-11-05 10:36 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, patches
The member reg_cache is not used at all and therefore it should be
removed. This member was usually needed for older versions of ASoC
that did not handle caching automatically and had to be done in the
driver itself.
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8776.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8776.c b/sound/soc/codecs/wm8776.c
index 04182c4..0132a27 100644
--- a/sound/soc/codecs/wm8776.c
+++ b/sound/soc/codecs/wm8776.c
@@ -34,7 +34,6 @@
/* codec private data */
struct wm8776_priv {
enum snd_soc_control_type control_type;
- u16 reg_cache[WM8776_CACHEREGNUM];
int sysclk[2];
};
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: WM8776: Removed unneeded struct member
2010-11-05 10:36 [PATCH] ASoC: WM8776: Removed unneeded struct member Dimitris Papastamos
@ 2010-11-06 11:01 ` Liam Girdwood
2010-11-06 15:12 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-11-06 11:01 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, Mark Brown, patches
On Fri, 2010-11-05 at 10:36 +0000, Dimitris Papastamos wrote:
> The member reg_cache is not used at all and therefore it should be
> removed. This member was usually needed for older versions of ASoC
> that did not handle caching automatically and had to be done in the
> driver itself.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8776: Removed unneeded struct member
2010-11-05 10:36 [PATCH] ASoC: WM8776: Removed unneeded struct member Dimitris Papastamos
2010-11-06 11:01 ` Liam Girdwood
@ 2010-11-06 15:12 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-11-06 15:12 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood
On Fri, Nov 05, 2010 at 10:36:24AM +0000, Dimitris Papastamos wrote:
> The member reg_cache is not used at all and therefore it should be
> removed. This member was usually needed for older versions of ASoC
> that did not handle caching automatically and had to be done in the
> driver itself.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-06 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-05 10:36 [PATCH] ASoC: WM8776: Removed unneeded struct member Dimitris Papastamos
2010-11-06 11:01 ` Liam Girdwood
2010-11-06 15:12 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).