From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Tommy.Zhu@wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Remove broken WM8350 direction constants
Date: Tue, 09 Nov 2010 18:26:23 +0000 [thread overview]
Message-ID: <1289327183.3290.13.camel@odin> (raw)
In-Reply-To: <1289305033-30397-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Tue, 2010-11-09 at 12:17 +0000, Mark Brown wrote:
> The WM8350 driver was using some custom constants to interpret the direction
> of the MCLK signal which had the opposite values to those used as standard
> by the ASoC core, causing confusion in machine drivers such as the 1133-EV1
> board.
>
> Reported-by: Tommy Zhu <Tommy.Zhu@wolfsonmicro.com>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-11-09 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 12:17 [PATCH] ASoC: Remove broken WM8350 direction constants Mark Brown
2010-11-09 18:26 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289327183.3290.13.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=Tommy.Zhu@wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).