From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: [PATCH] ASoC: tpa6130a2: Revisit power-up sequence
Date: Tue, 09 Nov 2010 21:39:54 +0000 [thread overview]
Message-ID: <1289338794.3290.43.camel@odin> (raw)
In-Reply-To: <1289206677-11886-1-git-send-email-jhnikula@gmail.com>
On Mon, 2010-11-08 at 10:57 +0200, Jarkko Nikula wrote:
> There are no known problems with current power-up sequence which first sets
> the /shutdown pin high and then enables the supply. However, swap the order
> so that the device is kept in shutdown/reset mode during the supply voltage
> transition since slowly rising voltages can usually cause problems if the
> device is not kept in reset.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> sound/soc/codecs/tpa6130a2.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-11-09 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 8:57 [PATCH] ASoC: tpa6130a2: Revisit power-up sequence Jarkko Nikula
2010-11-08 9:38 ` Peter Ujfalusi
2010-11-08 11:36 ` Mark Brown
2010-11-09 21:39 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289338794.3290.43.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).