From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Geoffrey Wossum <geoffrey@pager.net>
Cc: "gwossum@acm.org" <gwossum@acm.org>,
Sedji Gaouaou <sedji.gaouaou@atmel.com>,
Ryan Mallon <ryan@bluewatersys.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] Fix Atmel soc audio boards Kconfig dependency
Date: Thu, 11 Nov 2010 11:42:56 +0000 [thread overview]
Message-ID: <1289475776.3273.8.camel@odin> (raw)
In-Reply-To: <201011101709.56106.geoffrey@pager.net>
On Wed, 2010-11-10 at 17:09 -0600, Geoffrey Wossum wrote:
> On Wednesday 10 November 2010 3:54:08 pm Ryan Mallon wrote:
> > On 11/11/2010 10:04 AM, Liam Girdwood wrote:
> > > On Thu, 2010-11-11 at 09:02 +1300, Ryan Mallon wrote:
> > >> Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
> > >> audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing
> > >> clk_set_parent and clk_set_rate when building without
> > >> AT91_PROGRAMMABLE_CLOCKS.
> > >>
> > >> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
> > >
> > > Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
> >
> > Just realised that the PlayPaq board only appears in the sound/soc/atmel
> > directory. I cannot find a board file for it under either
> > arch/arm/mach-at91 or arch/avr32/. The updated patch below only changes
> > the dependency for the SAM9G20-EK board since I think the PlayPaq is
> > actually AVR32, and therefore should not depend on
> > AT91_PROGRAMMABLE_CLOCKS. This patch replaces my previous one.
>
> PlayPaq is an AT32AP7000 board, so the new patch is correct.
>
> > ---
> > Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
> > audio SAM9G20-EK board. Fixes link errors on missing clk_set_parent and
> > clk_set_rate when building without AT91_PROGRAMMABLE_CLOCKS.
> >
> > Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
>
> Acked-by: Geoffrey Wossum <gwossum@acm.org>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-11 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 20:02 [PATCH] Fix Atmel soc audio boards Kconfig dependency Ryan Mallon
2010-11-10 21:04 ` Liam Girdwood
2010-11-10 21:54 ` Ryan Mallon
2010-11-10 23:09 ` Geoffrey Wossum
2010-11-11 11:42 ` Liam Girdwood [this message]
2010-11-11 14:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289475776.3273.8.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=geoffrey@pager.net \
--cc=gwossum@acm.org \
--cc=ryan@bluewatersys.com \
--cc=sedji.gaouaou@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox