* [PATCH] ASoC: s3c24xx: test wrong variable
@ 2010-11-21 17:40 Vasiliy Kulikov
2010-11-22 13:46 ` Liam Girdwood
2010-11-22 14:00 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Vasiliy Kulikov @ 2010-11-21 17:40 UTC (permalink / raw)
To: kernel-janitors
Cc: Jassi Brar, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-kernel
After clk_get() mclk is checked three times instead of mout_epll
and sclk_spdif checks.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
Cannot compile this driver, so it is not tested.
sound/soc/s3c24xx/smdk_spdif.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/s3c24xx/smdk_spdif.c b/sound/soc/s3c24xx/smdk_spdif.c
index 11c88b1..761e02b 100644
--- a/sound/soc/s3c24xx/smdk_spdif.c
+++ b/sound/soc/s3c24xx/smdk_spdif.c
@@ -38,7 +38,7 @@ static int set_audio_clock_heirachy(struct platform_device *pdev)
}
mout_epll = clk_get(NULL, "mout_epll");
- if (IS_ERR(fout_epll)) {
+ if (IS_ERR(mout_epll)) {
printk(KERN_WARNING "%s: Cannot find mout_epll.\n",
__func__);
ret = -EINVAL;
@@ -54,7 +54,7 @@ static int set_audio_clock_heirachy(struct platform_device *pdev)
}
sclk_spdif = clk_get(NULL, "sclk_spdif");
- if (IS_ERR(fout_epll)) {
+ if (IS_ERR(sclk_spdif)) {
printk(KERN_WARNING "%s: Cannot find sclk_spdif.\n",
__func__);
ret = -EINVAL;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ASoC: s3c24xx: test wrong variable
2010-11-21 17:40 [PATCH] ASoC: s3c24xx: test wrong variable Vasiliy Kulikov
@ 2010-11-22 13:46 ` Liam Girdwood
2010-11-22 14:00 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-11-22 13:46 UTC (permalink / raw)
To: Vasiliy Kulikov
Cc: alsa-devel, Jassi Brar, Takashi Iwai, Mark Brown, kernel-janitors,
linux-kernel
On Sun, 2010-11-21 at 20:40 +0300, Vasiliy Kulikov wrote:
> After clk_get() mclk is checked three times instead of mout_epll
> and sclk_spdif checks.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile this driver, so it is not tested.
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: s3c24xx: test wrong variable
2010-11-21 17:40 [PATCH] ASoC: s3c24xx: test wrong variable Vasiliy Kulikov
2010-11-22 13:46 ` Liam Girdwood
@ 2010-11-22 14:00 ` Mark Brown
2010-11-22 21:53 ` Jassi Brar
1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2010-11-22 14:00 UTC (permalink / raw)
To: Vasiliy Kulikov
Cc: alsa-devel, Jassi Brar, Takashi Iwai, kernel-janitors,
linux-kernel, Liam Girdwood
On Sun, Nov 21, 2010 at 08:40:21PM +0300, Vasiliy Kulikov wrote:
> After clk_get() mclk is checked three times instead of mout_epll
> and sclk_spdif checks.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: s3c24xx: test wrong variable
2010-11-22 14:00 ` Mark Brown
@ 2010-11-22 21:53 ` Jassi Brar
2010-11-23 17:45 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Jassi Brar @ 2010-11-22 21:53 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, Jassi Brar, Takashi Iwai, kernel-janitors,
linux-kernel, Vasiliy Kulikov, Liam Girdwood
On Mon, Nov 22, 2010 at 11:00 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Sun, Nov 21, 2010 at 08:40:21PM +0300, Vasiliy Kulikov wrote:
>> After clk_get() mclk is checked three times instead of mout_epll
>> and sclk_spdif checks.
>>
>> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
>
> Applied, thanks.
Wierd, it is CC to me as well but I didn't receive it.
Though the change is ok.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: s3c24xx: test wrong variable
2010-11-22 21:53 ` Jassi Brar
@ 2010-11-23 17:45 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2010-11-23 17:45 UTC (permalink / raw)
To: Jassi Brar
Cc: alsa-devel, Jassi Brar, Takashi Iwai, kernel-janitors,
linux-kernel, Vasiliy Kulikov, Liam Girdwood
On Tue, Nov 23, 2010 at 06:53:58AM +0900, Jassi Brar wrote:
> Wierd, it is CC to me as well but I didn't receive it.
> Though the change is ok.
Could be greylisting - don't recall if the Samsung mail system does that
or not but I've seen issues with that causing random delays before.
Either that or the anti-spam system eating it.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-23 17:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-21 17:40 [PATCH] ASoC: s3c24xx: test wrong variable Vasiliy Kulikov
2010-11-22 13:46 ` Liam Girdwood
2010-11-22 14:00 ` Mark Brown
2010-11-22 21:53 ` Jassi Brar
2010-11-23 17:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).