From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Date: Mon, 29 Nov 2010 11:08:39 +0000 Message-ID: <1291028919.3299.137.camel@odin> References: <1291013698.19113.1.camel@mola> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f51.google.com (mail-ww0-f51.google.com [74.125.82.51]) by alsa0.perex.cz (Postfix) with ESMTP id 01E2E24527 for ; Mon, 29 Nov 2010 12:08:43 +0100 (CET) Received: by wwe15 with SMTP id 15so4426088wwe.20 for ; Mon, 29 Nov 2010 03:08:43 -0800 (PST) In-Reply-To: <1291013698.19113.1.camel@mola> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Axel Lin Cc: alsa-devel@alsa-project.org, Mark Brown , linux-kernel , Timur Tabi List-Id: alsa-devel@alsa-project.org On Mon, 2010-11-29 at 14:54 +0800, Axel Lin wrote: > Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL. > > Signed-off-by: Axel Lin > --- > sound/soc/fsl/mpc8610_hpcd.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c > index 0d7dcf1..7d7847a 100644 > --- a/sound/soc/fsl/mpc8610_hpcd.c > +++ b/sound/soc/fsl/mpc8610_hpcd.c > @@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "platform device add failed\n"); > goto error; > } > + dev_set_drvdata(&pdev->dev, sound_device); > > of_node_put(codec_np); > All Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk