From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "ext Olaya, Margarita" <magi.olaya@ti.com>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] ASoC: omap: Add hardware constraint for HDMI and ABE
Date: Wed, 08 Dec 2010 12:09:43 +0000 [thread overview]
Message-ID: <1291810183.3260.185.camel@odin> (raw)
In-Reply-To: <201012081111.40323.peter.ujfalusi@nokia.com>
On Wed, 2010-12-08 at 11:11 +0200, Peter Ujfalusi wrote:
> On Tuesday 07 December 2010 10:57:24 Ujfalusi Peter (Nokia-MS/Tampere) wrote:
> > On Tuesday 07 December 2010 00:34:44 ext Olaya, Margarita wrote:
> > > From: Jorge Eduardo Candelaria <jorge.candelaria@ti.com>
> > >
> > > The Audio Backend needs a step size of 24 * 4, while HDMI requires a
> > > step size of 32 * 4 bits to align the audio buffer.
>
> ...
>
> > Few things:
> > This only applicable for OMAP4, so please make it so that it only applies
> > to OMAP4.
> > We have the other constraints set in the
> > omap-mcbsp.c:omap_mcbsp_dai_startup. I think it would be better to keep
> > them in a same place.
>
> One more thing:
> Since this is ABE/HDMI specific constraint, I would add this from the
> corresponding codec driver rather than setting this for all McBSP ports
> regardless if it is used with HDMI or not.
>
I've spoken with Magi and this will be moved to the OAMP4 HDMI and ABE
DAI drivers only.
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-12-08 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:34 [PATCH 1/2] ASoC: omap: Add hardware constraint for HDMI and ABE Olaya, Margarita
2010-12-06 22:46 ` Mark Brown
2010-12-07 8:57 ` Peter Ujfalusi
2010-12-08 9:11 ` Peter Ujfalusi
2010-12-08 9:46 ` Mark Brown
2010-12-08 12:09 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291810183.3260.185.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=magi.olaya@ti.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox